Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPEC-321: Create instance at the and of AroundConstruct chain #4137

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@pdudits
Copy link
Contributor

commented Aug 9, 2019

SPEC-321: Create instance at the and of AroundConstruct chain

Producing the instance eagerly triggered interceptor chain too early with incomplete context, and instance was created after interceptors completed, not when end of chain was reached (i. e. in the middle of interceptors processing).

Also clean up unused imports and methods.

And trying to fix embedded shell, which sometimes build with incorrect MANIFEST.MF, causing tests with embedded EjbContainer to fail.

pdudits added 2 commits Aug 9, 2019
SPEC-321: Create instance at the and of AroundConstruct chain
Producing the instance eagerly triggered interceptor chain too early with
incomplete context, and instance was created after interceptors
completed, not when end of chain was reached.

Also clean up unused imports and methods.
Try to fix unstability of glassfish-embedded-shell
Module sometimes get built without manifest being updated, trying to raise
wait time to prevent any timestamp issues.

@pdudits pdudits requested review from Pandrex247 and MattGill98 Aug 9, 2019

@pdudits

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

Jenkins test please

@MattGill98
Copy link
Member

left a comment

LGTM, nice!

@MattGill98 MattGill98 merged commit 34ad29f into payara:master Aug 12, 2019

7 of 11 checks passed

security/snyk - appserver/common/pom.xml (payara-ci) Test in progress
security/snyk - appserver/installer/pom.xml (payara-ci) Test in progress
security/snyk - appserver/registration/pom.xml (payara-ci) Test in progress
security/snyk - appserver/transaction/pom.xml (payara-ci) Test in progress
Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.