Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-4043 Removed Jvnet parent #4139

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@dmatej
Copy link
Contributor

commented Aug 10, 2019

  • new parent relation introduced problems with it's configuration poisoning
    all it's grandchildren - profiles source and javadoc did not work.
    This is now fixed.
  • source and javadoc profiles now produce same artifacts as before
  • it is possible to combine profiles and build phases
  • removed duplicated and redundant configuration parts.
  • modules moved from profiles to the main pom.
  • aggregator also changed the id
@dmatej

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

Jenkins test please

@dmatej

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

This is an alternative PR to #4138

@pdudits
Copy link
Contributor

left a comment

When I did this in Payara BOM PR, I had to change few versions of dependencies that were indeed pulled from javanet. Didn't you have issues building with empty local repo?

pom.xml Outdated Show resolved Hide resolved
nucleus/pom.xml Show resolved Hide resolved
nucleus/pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@Pandrex247

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

@pdudits @dmatej Discussion from previous PR about naming of groupId:
#4062 (comment)

@dmatej

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

When I did this in Payara BOM PR, I had to change few versions of dependencies that were indeed pulled from javanet. Didn't you have issues building with empty local repo?

I think JVnet did not declare dependencies, only plugin dependencies, some of them were updated, but nothing big (I think it was only jar plugin and maybe source plugin).
Build with an empty local repo was successful.

@dmatej dmatej force-pushed the dmatej:PAYARA-4043-maven-plugin-hell branch from c26c215 to 99a0b05 Aug 12, 2019

@dmatej

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Jenkins test please

@dmatej dmatej requested a review from pdudits Aug 12, 2019

nucleus/pom.xml Show resolved Hide resolved
@pdudits

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

jenkins test please

PAYARA-4043 Removed Jvnet parent
- new parent relation introduced problems with it's configuration poisoning
  all it's grandchildren - profiles source and javadoc did not work.
  This is now fixed.
- source and javadoc profiles now produce same artifacts as before
- it is possible to combine profiles and build phases
- removed duplicated and redundant configuration parts.
- modules moved from profiles to the main pom.
- aggregator also changed the id

@dmatej dmatej force-pushed the dmatej:PAYARA-4043-maven-plugin-hell branch from 462b747 to 44165ca Aug 13, 2019

@dmatej

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

Jenkins test please

@dmatej dmatej merged commit 2bb484b into payara:master Aug 13, 2019

59 checks passed

Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/javaee-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details

@dmatej dmatej deleted the dmatej:PAYARA-4043-maven-plugin-hell branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.