Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-4104 Fixes NPE in monitoring console startup in case hazelcast is disabled #4188

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@jbee
Copy link
Contributor

commented Aug 30, 2019

PR fixes error reported in #4186 .

@jbee jbee self-assigned this Aug 30, 2019
@jbee jbee requested a review from Pandrex247 Aug 30, 2019
@jbee

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

jenkins test please

Copy link
Contributor

left a comment

\o/

Copy link
Contributor

left a comment

I quickbuild and skiptests on Windows 10, maybe environment issue but looks related?

./asadmin start-domain
Exception in thread "main" java.lang.IllegalStateException: The service 'org.glassfish.hk2.api.DynamicConfigurationService' could not be located by the locator 'ServiceLocatorImpl(__HK2_Generated_0,0,1909546776)'!
        at com.sun.enterprise.module.common_impl.AbstractModulesRegistryImpl.getServiceOrFail(AbstractModulesRegistryImpl.java:141)
        at com.sun.enterprise.module.common_impl.AbstractModulesRegistryImpl.initializeServiceLocator(AbstractModulesRegistryImpl.java:124)
        at com.sun.enterprise.module.common_impl.AbstractModulesRegistryImpl.newServiceLocator(AbstractModulesRegistryImpl.java:119)
        at com.sun.enterprise.module.common_impl.AbstractModulesRegistryImpl.createServiceLocator(AbstractModulesRegistryImpl.java:197)
        at com.sun.enterprise.module.common_impl.AbstractModulesRegistryImpl.createServiceLocator(AbstractModulesRegistryImpl.java:203)
        at com.sun.enterprise.module.single.StaticModulesRegistry.createServiceLocator(StaticModulesRegistry.java:64)
        at com.sun.enterprise.admin.cli.CLIContainer.getServiceLocator(CLIContainer.java:212)
        at com.sun.enterprise.admin.cli.CLIContainer.getLocalCommand(CLIContainer.java:244)
        at com.sun.enterprise.admin.cli.CLICommand.getCommand(CLICommand.java:240)
        at com.sun.enterprise.admin.cli.AdminMain.executeCommand(AdminMain.java:362)
        at com.sun.enterprise.admin.cli.AdminMain.doMain(AdminMain.java:298)
        at org.glassfish.admin.cli.AsadminMain.main(AsadminMain.java:56)
@jbee

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

@AlanRoth Does not look related to me but we can wait with the merge and look for more insight.

@AlanRoth

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

@jbee If you think it's unrelated, you're free to merge. :)

@svendiedrichsen

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

@jbee Would this fix lead to a release of Payara 5.193.1?

@dmatej

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

@AlanRoth Usually this is caused by one of these (on Linux):

  • JDK11 as default java program (no AS_HOME or JAVA_HOME set)
  • some instance is already running
@jbee

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

@svendiedrichsen I have a chat internal on a 5.193.1 release.

Copy link
Contributor

left a comment

Ignore my last comment, fix works :)

@jbee

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

@svendiedrichsen We feel that turning of hazelcast on DAS is so uncommon that a release isn't justified. There is an easy enough workaround in removing the monitoring-console-core.jar from glassfish/modules that can be applied by those that use the setting.

@jbee jbee merged commit ea9d3d8 into payara:master Aug 30, 2019
58 checks passed
58 checks passed
Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details
@svendiedrichsen

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

@svendiedrichsen We feel that turning of hazelcast on DAS is so uncommon that a release isn't justified. There is an easy enough workaround in removing the monitoring-console-core.jar from glassfish/modules that can be applied by those that use the setting.

Thanks for the info, @jbee .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.