Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-4120 Upgraded javax.annotation to jakarta.annotation #4208

Merged
merged 4 commits into from Sep 11, 2019

Conversation

@dmatej
Copy link
Contributor

dmatej commented Sep 9, 2019

  • fixes classloader issue on JDK11 that prevented the JDK to run anything including local asadmin commands
  • fixed also several other issues, see commits
@dmatej

This comment has been minimized.

Copy link
Contributor Author

dmatej commented Sep 9, 2019

Jenkins test please

Copy link
Contributor

jGauravGupta left a comment

javax.annotation-api artifact also defined in following pom.xml:

  • nucleus/packager/nucleus/src/main/assembly/nucleus.xml
  • appserver/tests/payara-samples/pom.xml
  • appserver/tests/payara-samples/samples/pom.xml
@dmatej

This comment has been minimized.

Copy link
Contributor Author

dmatej commented Sep 10, 2019

Good point, nucleus.xml is not a pom.xml, but it is assembly ... I have to find out why it is there ... and if I should only change it to jakarta or remove it completely
Samples are little bit aside, but you are right I should fix it too ... maybe it will fix crashes of samples on my system.
Thanks!

@dmatej dmatej force-pushed the dmatej:PAYARA-4120-jakarta-annotation-for-5.194 branch 2 times, most recently from 43b765d to ca0fecf Sep 10, 2019
@dmatej dmatej requested a review from jGauravGupta Sep 10, 2019
@dmatej

This comment has been minimized.

Copy link
Contributor Author

dmatej commented Sep 10, 2019

Payara-samples have incorrect dependency on payara, but I will address it in another PR.

@dmatej

This comment has been minimized.

Copy link
Contributor Author

dmatej commented Sep 10, 2019

Jenkins test please

@dmatej

This comment has been minimized.

Copy link
Contributor Author

dmatej commented Sep 11, 2019

Jenkins test please

@dmatej

This comment has been minimized.

Copy link
Contributor Author

dmatej commented Sep 11, 2019

Jenkins test please

@dmatej dmatej added the DO NOT MERGE label Sep 11, 2019
@dmatej

This comment has been minimized.

Copy link
Contributor Author

dmatej commented Sep 11, 2019

Run Jenkins and merge after #4210 would be in master.

dmatej added 4 commits Sep 9, 2019
- fixes classloader issue on JDK11 that prevented the JDK to run anything
- javax.annotation removed from nucleus dependencies (was already excluded in assembly)
- payara-minimal enabled again, does not crash any more because of this
- removed dependency from payara-samples - it is not needed.
- jar files are ordered by a filename
- clean code
- implemented toString, listing all dependencies
- throws IllegalStateException (parent, the URLClassloader, throws IAE, SecurityException, NPE)
- removed dangerous unused method getJarForClass
- caused by the 0861f66 - incorrect rebase
@dmatej dmatej force-pushed the dmatej:PAYARA-4120-jakarta-annotation-for-5.194 branch from 55191a1 to 3b04aea Sep 11, 2019
@dmatej dmatej removed the DO NOT MERGE label Sep 11, 2019
@dmatej

This comment has been minimized.

Copy link
Contributor Author

dmatej commented Sep 11, 2019

Jenkins test please

@dmatej

This comment has been minimized.

Copy link
Contributor Author

dmatej commented Sep 11, 2019

Payara-Samples is resolved also here #4214

@dmatej dmatej merged commit f1ff595 into payara:master Sep 11, 2019
58 checks passed
58 checks passed
Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details
@dmatej dmatej deleted the dmatej:PAYARA-4120-jakarta-annotation-for-5.194 branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.