Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-4195 Cleanup related to deployment-client #4253

Merged

Conversation

@dmatej
Copy link
Contributor

dmatej commented Oct 4, 2019

Description

This is only additional PR to #4247 adding some cleanups I and my Eclipse made while working on issues with deployment-client and TCK. I didn't want to mix it with original PR.

Main differences:

  1. deploy first deploys the module to the domain, then creates references (originally deployed to first target it received and created reference automatically; then developers added magic to avoid clashes on redeployments)
  2. undeploy first removes all references, then undeploys the module (originally removed all references except last and for that called undeploy; existed error scenarios causing failures in undeploy phase)
  3. ApplicationLifecycle.getArchiveHandler - fixed NPE

Look into individual commits for more details.

Test suites executed

  • Quicklook
  • Jakarta TCKs (j2eetools)
@dmatej dmatej requested a review from pdudits Oct 4, 2019
@dmatej

This comment has been minimized.

Copy link
Contributor Author

dmatej commented Oct 4, 2019

Jenkins test please

dmatej added 3 commits Oct 4, 2019
- code formatting
- fixed several potential NPE
- deleted unused or commented out code
- deleted copypasted javadoc (from impl if same in interface)
- added logging
- added toStrings to ID objects
- changed behavior - deploy/undeploy always to domain,
  resolve references separately
- GlassfishNamingManagerImpl
  - annotations, finals
- BaseContainer
  - annotations, finals, emhanced loops
- EJBSecurityManager
  - removed unused field and related log
- DatadogMonitoringNotifierConfigurer
  - duplicit semicolon making my eclipse nervous
- OpenTracingRequestEventListener
  - log also path
- ApplicationLifecycle
  - bit of formatting
  - generics
  - fixed NPE in getArchiveHandler
- DeploymentProperties
  - comments transformed to javadoc
  - iterator, serialuuid
- narrowed IOException variables (still ugly copypasted impl)
- writeMemoryMappedArchiveToTempFile used overengineered impl to save byte array
  to a file. There is no need to create several additional byte buffers
  and copy all data through them when we already have a byte array.
@dmatej dmatej force-pushed the dmatej:PAYARA-4195-cleanup-deployment-client-master branch from ce6bdc3 to 5bf88e8 Oct 8, 2019
@dmatej dmatej requested a review from pdudits Oct 8, 2019
@dmatej

This comment has been minimized.

Copy link
Contributor Author

dmatej commented Oct 8, 2019

Jenkins test please

@dmatej dmatej self-assigned this Oct 8, 2019
@pdudits
pdudits approved these changes Oct 9, 2019
@dmatej dmatej merged commit b6c0703 into payara:master Oct 9, 2019
32 of 36 checks passed
32 of 36 checks passed
security/snyk - appserver/appclient/pom.xml (payara-ci) Test in progress
security/snyk - appserver/web/pom.xml (payara-ci) Test in progress
security/snyk - nucleus/hk2/pom.xml (payara-ci) Test in progress
security/snyk - nucleus/security/pom.xml (payara-ci) Test in progress
Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
@dmatej dmatej deleted the dmatej:PAYARA-4195-cleanup-deployment-client-master branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.