Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
PAYARA-4195 Cleanup related to deployment-client #4253
This is only additional PR to #4247 adding some cleanups I and my Eclipse made while working on issues with deployment-client and TCK. I didn't want to mix it with original PR.
Look into individual commits for more details.
Test suites executed
- code formatting - fixed several potential NPE - deleted unused or commented out code - deleted copypasted javadoc (from impl if same in interface) - added logging - added toStrings to ID objects - changed behavior - deploy/undeploy always to domain, resolve references separately
- GlassfishNamingManagerImpl - annotations, finals - BaseContainer - annotations, finals, emhanced loops - EJBSecurityManager - removed unused field and related log - DatadogMonitoringNotifierConfigurer - duplicit semicolon making my eclipse nervous - OpenTracingRequestEventListener - log also path - ApplicationLifecycle - bit of formatting - generics - fixed NPE in getArchiveHandler - DeploymentProperties - comments transformed to javadoc - iterator, serialuuid
- narrowed IOException variables (still ugly copypasted impl) - writeMemoryMappedArchiveToTempFile used overengineered impl to save byte array to a file. There is no need to create several additional byte buffers and copy all data through them when we already have a byte array.