Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-4193 Monitoring Console Various Improvments #4274

Merged
merged 11 commits into from Oct 24, 2019

Conversation

@jbee
Copy link
Contributor

jbee commented Oct 16, 2019

Summary

Improvements include:

  • Widget have dedicated unit
  • Axis labelling with units
  • Possibility to set axis min/max value
  • Presets for Core (with 6th HTTP Threadpool count), HTTP and Request Tracing
  • Possibility to set waterline vale (baseline, limit)
  • Possibility to set alarming and critical thresholds
  • Request statistics for individual web-applications is collected
  • Possibility to set status texts (used in presets to help user to understand that some series require configuration)
  • peset pages are always added when missing
  • web resources organised on subfolders (/js/, /css/, ...)

Note for Reviewers

Note that monitoring-console.js is a generated merged file of the other JS files and does not need individual review.

Testing

  1. To test the server needs to be build, installed and MC webapp in appserver/monitoring-console/webapp/ be deployed on the installation.
  2. When started open the app in the browser at http://localhost:8080/monitoring-console-webapp/

You should see a view similar to the below:
PAYARA-4193-mc-improvments

Some points to note comparing to the unimproved version before:

  • web based metrics need to be enabled as they point out by a message
  • HTTP based metric is available but most likely isn't yet enabled for you (similar message)
  • server is now given as DAS in legend (also note tooltip)
  • main (current value) line is now thicker for better visibility in monitor screen scenario
  • x-axis has labels with unit, %, ms, or count /s
  • y-axis has labels from now (right) to x s ago (x usually 60) on left
  • legend now has value with unit
  • legend show values per second as an average of last few values (otherwise it could show zero at point of update even though in between values were non-zero which seams wrong)
  • legend now distinguishes between No Data and Lost Connection (undeploy webapp to see)
  • CPU Usage and Heap Usage have additional red and yellow lines indicating the set alarming and critical level (see Decorations in image below)

When selecting a widget by clicking on the metric name in the caption the side panel shows its configuration similar to seen below:
PAYARA-4193-mc-improvments-side-panel

Points to note about the side panel in general:

  • configuration is now organised more structured having multiple inputs for a row where it makes sense
  • no stacked groupings are used any more

Points to note about the Data box:

  • a Unit can be chosen controlling what the data means
  • a min and max value for Y-Axis can be set
  • X-Axis labelling can be turned on/off

Points to note about the Decorations box:

  • Decorations are client side visuals added to a chart entered in the charts unit, e.g. % or ms
  • A Waterline is just a visual indicator of some baseline or limit a user wants to add
  • 2 thresholds can be added: alarming and critical
  • Alarming Threshold: when value exceeds limit the exceeding series flashes yellow in the legend
  • Critical Threshold: when value exceeds limit the exceeding series flashes red in the legend
  • the value the thresholds are compared to is configurable and chosen by Threshold Reference
  • if critical is below alarming threshold exceeding mean to be less then otherwise it is grater then

Points to note about the Status box:

  • The status of a metric is a client side assessment of the data using thresholds and data, it can be either normal, alarming, critical, missing or error
  • the user can enter hint messages for the case the assessment concludes the state "No Data" (missing), "Alarming" or "Critical". This is used by the presets to setup the message to show in case there is no data for a web or HTTP based metric that needs to be enabled in the server's Monitoring configuration

To test the application specific metrics added the Web Container monitoring has to be set to HIGH. Now when opening the side panel look at the Page box at the top.
The dropwdown now has metrics in web section where the name includes @:monitoring-console-webapp. These are metrics specific for that application.

jbee added 6 commits Oct 9, 2019
@jbee jbee self-assigned this Oct 16, 2019
@jbee

This comment has been minimized.

Copy link
Contributor Author

jbee commented Oct 17, 2019

jenkins test please

@jbee

This comment has been minimized.

Copy link
Contributor Author

jbee commented Oct 22, 2019

jenkins test please

@jbee

This comment has been minimized.

Copy link
Contributor Author

jbee commented Oct 23, 2019

jenkins test please

1 similar comment
@jbee

This comment has been minimized.

Copy link
Contributor Author

jbee commented Oct 23, 2019

jenkins test please

@jGauravGupta

This comment has been minimized.

Copy link
Contributor

jGauravGupta commented Oct 23, 2019

monitoring-console-webapp functioning well as per details mentioned above but on adding the new widgets, It always added to the first column instead of arrangement in flow layout even after refreshing the console webpage:

scr

scr2

@jbee

This comment has been minimized.

Copy link
Contributor Author

jbee commented Oct 24, 2019

Thanks @jGauravGupta for the review. The behaviour you describe when adding widgets is inconvenient but expected - haven't spend time making this more fancy - but I made a note so I don't forget to address it sometime soon.

@jbee jbee added this to the 5.194 milestone Oct 24, 2019
@jbee jbee merged commit 14ae2ca into payara:master Oct 24, 2019
58 checks passed
58 checks passed
Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.