Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3796 Stop checking whether the JNDI name refers to a String ju… #4284

Merged
merged 2 commits into from Nov 21, 2019

Conversation

@smillidge
Copy link
Contributor

smillidge commented Oct 26, 2019

…st use toString instead if the lookup suceeds.

Fixes GH #3935

Signed-off-by: Steve Millidge steve.millidge@payara.fish

Description

This is a small enhancement it enables use of other types of custom JNDI resources other than Strings to be injected as ConfigProperties

#3935

The JNDI config source was explicitly testing whether the object looked up via JNDI was assignable to a String. This is unnecessarily restrictive therefore now it just does a toString.

Testing

New tests

Testing Performed

Tested using the GH reproducer.

Test suites executed

Testing Environment

1.8.0_23
Ubuntu Linux version 5.0.0-31-generic (buildd@lgw01-amd64-046) (gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu118.04.1)) #3318.04.1-Ubuntu SMP Tue Oct 1 10:20:39 UTC 2019

Documentation

Notes for Reviewers

…st use toString instead if the lookup suceeds.

Fixes GH #3935

Signed-off-by: Steve Millidge <steve.millidge@payara.fish>
@smillidge

This comment has been minimized.

Copy link
Contributor Author

smillidge commented Oct 26, 2019

Jenkins test please

@smillidge smillidge added this to the 5.194 milestone Oct 26, 2019
@Cousjava

This comment has been minimized.

Copy link
Member

Cousjava commented Oct 28, 2019

Copyright year needs updating

@pdudits

This comment has been minimized.

Copy link
Contributor

pdudits commented Nov 21, 2019

Jenkins test please

@pdudits pdudits merged commit f9b2e69 into payara:master Nov 21, 2019
7 of 10 checks passed
7 of 10 checks passed
security/snyk - appserver/installer/pom.xml (payara-ci) Test in progress
security/snyk - appserver/transaction/pom.xml (payara-ci) Test in progress
security/snyk - nucleus/packager/pom.xml (payara-ci) Test in progress
Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.