Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
PAYARA-4251 Woodstock cleanup (a bit of) #4299
This is a build improvement - it is simplier and faster.
Following branches/PR do not block this PR, but they are related (can be used to test it):
Manual testing done:
I know, I found it later (even Andrew did not remember) ... and the second thing is that it is not usable. It is only a copy of files, as it is written in some JIRA issue.
At least I know how it works and now we can release templates without renumbering this artifact.
The latest upstream woodstock is at https://github.com/eclipse-ee4j/glassfish-woodstock, which is buildable.
- reduced dependency management without impact (console-core) - admingui war module - using Maven only, no Ant needed - Manifest is generated - no repacking, proper dependency management is faster and without mysteries - sun-web.xml - using Maven filtering, no hardcoded versions - appserver/pom.xml - using properties to define versions - properties are used also for filtering sun-web.xml - sources - code formatting, logging - result: upgrade means only changing the version property, checking changes in artifact dependencies and testing. You can use also snapshots.
- no default dependencies (or less than before at least) - dependency management uses provided scope as a default - removed redundant relativePath elements (../pom.xml is default!) - removed some dead code - commented out parts - admin gui war uses admingui parent, does not skip it to payara-parent - it's dependencies moved here if not used in any other module outside - console-common - changed order of dependencies - our first, external after that, classpath conflicts will prefer our implementation (but it does not apply to the runtime Payara Server, only for build!) - dataprovider - osgi repackaging of the woodstock artifact => the original artifact is excluded from all dependencies and only our is used - imqjmx vs. admingui - not used in admingui, even not packaged - packaged in other featuresets - tested: resulting zip file contains same 4 files with imqjmx in name as it contained before - jsftemplating - dependency shared also by admingui plugins, that's why it is not included in the war file, it is included by the packager to the the admingui featureset