Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-4192 Support explicitly setting Data-Grid port in an instance #4341

Merged
merged 12 commits into from Nov 25, 2019

Conversation

@MeroRai
Copy link
Contributor

MeroRai commented Nov 21, 2019

Description

This is a feature to support explicitly setting Data-Grid port in an instance.

Important Info

This allows more control over the port usage by letting users set the Data Grid port during the creation of an instance. The user can set an individual start port to each instance using either asadmin CLI or the admin console.

Example of create-instance command: ./asadmin create-instance --dataGridStartPort 2900 --node localhost-domain1 instance1.

Example of set-hazelcast-configuration command : ./asadmin set-hazelcast-configuration --dynamic=true --configSpecificDataGridStartPort=4900 --target=instance-config

Testing

New tests

Testing Performed

  • Ran the command mentioned above and made sure instances cluster in Data Grid.
  • Set instance Data Grid start port using the admin console and made sure the port change happens.

Test suites executed

Testing Environment

Zulu JDK 1.8_222 on Elementary OS 0.4.1 Loki with Maven 3.5.4

Documentation

TODO

Notes for Reviewers

@MeroRai MeroRai requested a review from Cousjava Nov 21, 2019
@MeroRai MeroRai self-assigned this Nov 21, 2019
@MeroRai MeroRai changed the title Support explicitly setting Data-Grid port in an instance PAYARA-4192 Support explicitly setting Data-Grid port in an instance Nov 21, 2019
@MeroRai

This comment has been minimized.

Copy link
Contributor Author

MeroRai commented Nov 21, 2019

jenkins test please

Copy link
Member

Pandrex247 left a comment

Couple of points, but otherwise seems to work!

MeroRai and others added 5 commits Nov 22, 2019
…zelcast/hazelcastLocal.jsf

Co-Authored-By: Andrew Pielage <pandrex247@hotmail.com>
…n/cluster/CreateInstanceCommand.java

Co-Authored-By: Andrew Pielage <pandrex247@hotmail.com>
…/cluster/CreateLocalInstanceCommand.java

Co-Authored-By: Andrew Pielage <pandrex247@hotmail.com>
…sh/payara/admingui/extras/Strings.properties

Co-Authored-By: Andrew Pielage <pandrex247@hotmail.com>
…payara/nucleus/hazelcast/admin/SetHazelcastConfiguration.java

Co-Authored-By: Andrew Pielage <pandrex247@hotmail.com>
@MeroRai

This comment has been minimized.

Copy link
Contributor Author

MeroRai commented Nov 22, 2019

jenkins test please

@MeroRai

This comment has been minimized.

Copy link
Contributor Author

MeroRai commented Nov 25, 2019

jenkins test please

@Pandrex247 Pandrex247 merged commit 009051f into payara:master Nov 25, 2019
58 checks passed
58 checks passed
Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.