Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUSTCOM-144 Avoid NPEx on unboxing null Boolean (javaee/glassfish 22406) #4408

Merged
merged 2 commits into from Jan 9, 2020

Conversation

@pzygielo
Copy link
Contributor

pzygielo commented Jan 3, 2020

Description

This is a bug fix, for issue originally reported against javaee/glassfish (22406).

Testing

New tests

New UT FilterDefDecoratorTest.nullAsyncSupportedFlagShallNotCauseException.

Testing Performed

A. mvn clean install

  1. for first commit to make sure UT fails
  2. for second commit to make sure it fixes FilterDefDecorator and doesn't break the build in other parts.

B. With distribution built in step A2 - Steps to reproduce from 22406, but with step 7 producing expected welcome page.

Test suites executed

Only included in full build with command above.

Testing Environment

A. Ubuntu 16.04.6 LTS, OpenJDK Runtime Environment (build 1.8.0_222-8u222-b10-1ubuntu1~16.04.1-b10), maven 3.6.3
B. GNU/Linux, OpenJDK Runtime Environment (build 1.8.0_232-b09), maven 3.6.3

pzygielo added 2 commits Jan 3, 2020
Fixes eclipse-ee4j/glassfish 22406
@jGauravGupta

This comment has been minimized.

Copy link
Contributor

jGauravGupta commented Jan 4, 2020

jenkins test please

@Cousjava Cousjava changed the title Avoid NPEx on unboxing null Boolean (javaee/glassfish 22406) CUSTCOM-144 Avoid NPEx on unboxing null Boolean (javaee/glassfish 22406) Jan 8, 2020
@dmatej
dmatej approved these changes Jan 9, 2020
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>${mockito.version}</version>

This comment has been minimized.

Copy link
@dmatej

dmatej Jan 9, 2020

Contributor

Version and scope are redundant, they are already defined in payara-nucleus-parent, am I right?

This comment has been minimized.

Copy link
@dmatej

dmatej Jan 9, 2020

Contributor

Answer to myself: no, not in master yet ...

This comment has been minimized.

Copy link
@pzygielo

pzygielo Jan 9, 2020

Author Contributor

Answer to myself: no, not in master yet ...

But I have such change waiting on my branch! Really! 😄

This comment has been minimized.

Copy link
@pzygielo

pzygielo Jan 9, 2020

Author Contributor

Version and scope are redundant, they are already defined in payara-nucleus-parent, am I right?

I've just proposed #4418 to make it so.

This comment has been minimized.

Copy link
@dmatej

dmatej Jan 9, 2020

Contributor

You are too fast, now I will have some conflicts, but nevermind, they will be trivial ;)
Thanks!

@dmatej dmatej merged commit cce6338 into payara:master Jan 9, 2020
58 checks passed
58 checks passed
Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details
@pzygielo pzygielo deleted the pzygielo:issue_gf_22406 branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.