Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUSTCOM-203 Referenced component name in OpenApi 'paths' sec… #4494

Merged
merged 5 commits into from Feb 20, 2020

Conversation

@Pscheidl
Copy link

Pscheidl commented Feb 14, 2020

…tion use name from the Schema annotation

Description

This is a bug fix of #4490

Important Info

Testing

Created test class OASchemaReferenceNameTest. Tests whether the name is picked up from the Schema annotation, if present and the name is not empty (default is empty). Otherwise it will use simple name of the class - which is in line with how the "components" schemas behave.

Testing Environment

JDK 1.8.0_241

Documentation

Notes for Reviewers

OASchemaReferenceNameTest and its schemaComponentReferenceNaming method. The test class is self-contained - everything required for this particular test case is there.

@Pscheidl Pscheidl force-pushed the Pscheidl:microprofile-4490 branch 4 times, most recently from cda0b02 to 3591fcc Feb 14, 2020
…tion use name from the Schema annotation
@Pscheidl Pscheidl force-pushed the Pscheidl:microprofile-4490 branch from 3591fcc to e7d2918 Feb 14, 2020
@Pscheidl

This comment has been minimized.

Copy link
Author

Pscheidl commented Feb 14, 2020

Removed unnecessary formatting changes. Ready to be reviewed I believe.

@Pscheidl Pscheidl requested review from jbee and MattGill98 Feb 14, 2020
@smillidge

This comment has been minimized.

Copy link
Contributor

smillidge commented Feb 14, 2020

Fantastic. Thanks for the contribution Pavel.
I can't find a CLA on record can you print and scan as described in https://github.com/payara/Payara/blob/master/.github/CONTRIBUTING.md

@Pscheidl

This comment has been minimized.

Copy link
Author

Pscheidl commented Feb 14, 2020

Fantastic. Thanks for the contribution Pavel.
I can't find a CLA on record can you print and scan as described in https://github.com/payara/Payara/blob/master/.github/CONTRIBUTING.md

My apologies, I overlooked that. Of course, I'll happily send it late this evening.

@Pscheidl

This comment has been minimized.

Copy link
Author

Pscheidl commented Feb 15, 2020

Sent.

@rdebusscher rdebusscher linked an issue that may be closed by this pull request Feb 18, 2020
@Pscheidl Pscheidl requested a review from rdebusscher Feb 18, 2020
@Pscheidl Pscheidl force-pushed the Pscheidl:microprofile-4490 branch from 369794a to e3fd7d2 Feb 18, 2020
@rdebusscher

This comment has been minimized.

Copy link
Contributor

rdebusscher commented Feb 18, 2020

Jenkins test please

@jbee
jbee approved these changes Feb 19, 2020
Copy link
Contributor

jbee left a comment

Thanks @Pscheidl , looks good.

2 minor changes but nothing mandatory.

Pavel Pscheidl added 2 commits Feb 19, 2020
Pavel Pscheidl
@jbee
jbee approved these changes Feb 19, 2020
@jbee

This comment has been minimized.

Copy link
Contributor

jbee commented Feb 20, 2020

jenkins test please

@jbee jbee merged commit ea44437 into payara:master Feb 20, 2020
58 checks passed
58 checks passed
Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details
@MattGill98 MattGill98 changed the title MICROPROFILE #4490 - Referenced component name in OpenApi 'paths' sec… CUSTCOM-203 Referenced component name in OpenApi 'paths' sec… Feb 20, 2020
@Pscheidl Pscheidl deleted the Pscheidl:microprofile-4490 branch Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.