Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-5753 Corba Read Timeout in Buffer Manager #5448

Merged
merged 5 commits into from Oct 19, 2021

Conversation

Pandrex247
Copy link
Member

Description

CORBA occasionally encounters a communication error whilst running clients against our EJBs on the Payara application server, typically when transferring large byte arrays.

Original GlassFish ORB issue: eclipse-ee4j/orb#6

Takes the fix (eclipse-ee4j/orb#41) provided in later versions of CORBA and backports it to our patched fork.

Added a the reproducer from the original issue as an automated test, but left it disabled as from my personal testing I found it typically took around 30-40 minutes before it encountered the reported error against unpatched master.

Important Info

Blockers

Patched Project PR: payara/patched-src-glassfish-corba#13

Testing

New tests

Sample added, but disabled because it takes about 45 minutes to run meaningfully.

Testing Performed

Ran the reproducer against master for about 70 minutes to reproduce twice.
Ran the reproducer against this patched branch for 150 minutes and never got it to happen again.

Testing Environment

Windows 10, JDK 8.

Documentation

N/A

Notes for Reviewers

See description above - the reproducer for this issue taking 30-40 minutes to trip it is a bit pants

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247
Copy link
Member Author

Jenkins test please

1 similar comment
@Pandrex247
Copy link
Member Author

Jenkins test please

Copy link
Contributor

@aubi aubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pandrex247
Copy link
Member Author

Jenkins test please

@Pandrex247
Copy link
Member Author

Jenkins test please

@Pandrex247 Pandrex247 merged commit 5e455a3 into payara:master Oct 19, 2021
@Pandrex247 Pandrex247 deleted the FISH-5753 branch October 19, 2021 10:49
JamesHillyard pushed a commit to JamesHillyard/Payara that referenced this pull request Oct 28, 2021
FISH-5753 Corba Read Timeout in Buffer Manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants