New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing transaction recovery when OSGi applications are present. (Payara-659) #681
Conversation
…ixes payara#679 OSGi applications do not have Application metadata, leading to NPE.
Can one of the admins verify this patch? |
You can get OSGI apps with EJBs see issue #673. We need to ensure we test this scenario when merging. |
Oh yes, OSGi hybrid apps is the only feature we don't use in my project (anymore :)) But as I remember the way it worked, it was OSGi extenders bridging to the containers, and EJB engine was not associated with the app. So I'd expect these will also have empty metadata and |
Hi @pdudits , if you tell me how to check the isJavaEE flag I'd be happy to do it here on my installation. Can I query that flag via some console or do I have to debug a running Payara? Can it maybe be seen when I turn up some logging? Thanks, Edit: just checked a heap dump. For the hybrid OSGi apps the flag isJavaEEApp is set to false. |
@chrjohn Exactly, I was looking at the heap dump. Can you please check if |
@pdudits Yes, When checking the deployed modules on my payara installation it seems that only hybrid bundles with MDBs are flagged as non-JavaEE apps. Hybrid bundles containing session beans are flagged as JavaEE app. |
What matters is, that when the app |
Yes, I can confirm that JavaEE apps have the |
Tagged as Payara-659 internally |
@pdudits Can you attach or link a test case please? The change looks like it makes sense, but I'd like to see and run your tests on our end before merging the change. Thanks |
Hi, The general test case is:
As for actual test scenario, I was migrating a project from Glassfish 3.1.2 onto Payara, and I cannot share the application(s) involved here. |
jenkins test please |
All tests have passed |
FISH-6495 : verifying if property was passed
…Fixes #679
OSGi applications do not have (EE) Application metadata, leading to NPE at line 267