New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve com.sun.aas.instanceName in JVM arguments (PAYARA-660) #683
Conversation
Can one of the admins verify this patch? |
Tagged as PAYARA-660 internally |
jenkins test please |
I have reviewed the changes and everything seems in order. I will merge once the test suite confirms. |
All tests have passed |
Resolve com.sun.aas.instanceName in JVM arguments (PAYARA-660)
We have reverted this issue for now because on second review we are unsure what this addition is achieving. Could you please provide clarification as to what your problem is and what your intended fix is? We've debugged this area of code, and we're not sure what your "resolving" issue is. For the DAS, it is already resolved as server at this point, which your fix does not change. In addition, if you specify the instance name in the domain.xml, it will always resolve as this once it hits the For an instance, the instance name is null by default, but it is resolved as what you pass in with |
In my case I've got Value for instanceName is not present in the map at point of process start, therefore the process is started with value of the property The system property is eventually set, but it is too late for logging subsystem, that writes out log events directly after the process is started, and only resolves the property once, therefore I've put it in Another example would be usage for I'll check once again if the resolution did not work for other reason, but the problem definetely did not occur after this line was added. |
No, in my debugging session, without the patch, the token |
Ok, thanks for the information and prompt reply. I am afraid I misunderstood what you were doing. |
I have merged the fix back in, thanks for your contribution. |
PAYARA-3881 - 5.191 Maintenance Approved-by: Jonathan Coustick <jonathan.coustick@payara.fish>
…reateSocket-method-to-fix-ldap-bug FISH-6567: override createSocket method without arguments to fix ldap connection issue
com.sun.aas.instanceName
is the only glassfish system property that will not resolve when passed as JVM argument, which is strange omission.In my use case I redirect all logging to logback, and logback gets initialized earlier than the system property is set during appserver startup. Passing it in JVM arguments guarantees it is available right from the process start.