New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-249 Payara Micro Maven Deployer #687

Merged
merged 3 commits into from Mar 16, 2016

Conversation

Projects
None yet
4 participants
@Pandrex247
Contributor

Pandrex247 commented Mar 1, 2016

Allows you to deploy artefacts stored in Maven repositories by providing GAV (group, artefact, version) coordinates as comma separated Strings (e.g. fish.payara.examples,test,1.1), and repository URLs.

Defaults to looking for provided artefacts in Maven central if no additional repositories are provided.

Also removes an unused constructor and tidies up some comments.

@smillidge

This comment has been minimized.

Show comment
Hide comment
@smillidge

smillidge Mar 14, 2016

Contributor

jenkins test please

Contributor

smillidge commented Mar 14, 2016

jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Mar 14, 2016

Contributor

All tests have passed

Contributor

payara-ci commented Mar 14, 2016

All tests have passed

@smillidge

This comment has been minimized.

Show comment
Hide comment
@smillidge

smillidge Mar 15, 2016

Contributor

jenkins test please

Contributor

smillidge commented Mar 15, 2016

jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Mar 15, 2016

Contributor

All tests have passed

Contributor

payara-ci commented Mar 15, 2016

All tests have passed

@Pandrex247

This comment has been minimized.

Show comment
Hide comment
@Pandrex247

Pandrex247 Mar 16, 2016

Contributor

Rebased and conflicts resolved.

Contributor

Pandrex247 commented Mar 16, 2016

Rebased and conflicts resolved.

@smillidge

This comment has been minimized.

Show comment
Hide comment
@smillidge

smillidge Mar 16, 2016

Contributor

jenkins test please

Contributor

smillidge commented Mar 16, 2016

jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Mar 16, 2016

Contributor

All tests have passed

Contributor

payara-ci commented Mar 16, 2016

All tests have passed

smillidge added a commit that referenced this pull request Mar 16, 2016

Merge pull request #687 from Pandrex247/PAYARA-249-Payara-Micro-Maven…
…-Deployer

PAYARA-249 Payara Micro Maven Deployer

@smillidge smillidge merged commit 6123cd0 into payara:master Mar 16, 2016

1 check passed

default Build finished. No test results found.
Details
@OndrejM

This comment has been minimized.

Show comment
Hide comment
@OndrejM

OndrejM Oct 24, 2016

Contributor

Is there any reason why comma (,) is used as a separator in GAV? In maven world, usually a colon (:) is used as a separator. As a user, I'd like to use colon as a separator, because I'm used to it and it is also easy to copy and paste from places, where the same separator is already used.

Contributor

OndrejM commented Oct 24, 2016

Is there any reason why comma (,) is used as a separator in GAV? In maven world, usually a colon (:) is used as a separator. As a user, I'd like to use colon as a separator, because I'm used to it and it is also easy to copy and paste from places, where the same separator is already used.

@Pandrex247

This comment has been minimized.

Show comment
Hide comment
@Pandrex247

Pandrex247 Oct 26, 2016

Contributor

It's been 7 months since I properly looked at it, but no I can't remember there being any particular reason I used a comma over a colon to separate the GAV elements. Raise an enhancement request if you'd like this put in - I imagine we can come up with something to allow both commas and colons to prevent breaking anyone's scripts.

Contributor

Pandrex247 commented Oct 26, 2016

It's been 7 months since I properly looked at it, but no I can't remember there being any particular reason I used a comma over a colon to separate the GAV elements. Raise an enhancement request if you'd like this put in - I imagine we can come up with something to allow both commas and colons to prevent breaking anyone's scripts.

@Pandrex247 Pandrex247 deleted the Pandrex247:PAYARA-249-Payara-Micro-Maven-Deployer branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment