Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-4000 A REST management DELETE command returns 415 code instead of 404 #31

Conversation

@AlanRoth
Copy link

commented Aug 15, 2019

No description provided.

@AlanRoth AlanRoth requested a review from MattGill98 Aug 15, 2019

@MattGill98
Copy link
Member

left a comment

You seem to have jumped from p3-SNAPSHOT -> p5 -> p5-SNAPSHOT, whereas the correct order should be p3-SNAPSHOT -> p3 -> p4-SNAPSHOT

@AlanRoth AlanRoth force-pushed the AlanRoth:jersey-2.29.payara-maintenance branch from d004dde to faf2bbf Aug 16, 2019

@AlanRoth AlanRoth requested a review from MattGill98 Aug 16, 2019

AlanRoth added 2 commits Aug 14, 2019
Merge pull request #29 from AlanRoth/PAYARA-4000
PAYARA-4000 A REST management DELETE command returns 415 code instead of 404

@AlanRoth AlanRoth force-pushed the AlanRoth:jersey-2.29.payara-maintenance branch from faf2bbf to 40bf385 Aug 16, 2019

@AlanRoth AlanRoth changed the title A REST management DELETE command returns 415 code instead of 404 PAYARA-4000 A REST management DELETE command returns 415 code instead of 404 Aug 16, 2019

@MattGill98
Copy link
Member

left a comment

My fault, but I've just checked and the tests sem to fail:

WARNING: Entity must be null for http method DELETE.
[ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.075 s <<< FAILURE! - in org.glassfish.jersey.client.JerseyInvocationTest
[ERROR] overrideHttpMethodBasedComplianceCheckTest(org.glassfish.jersey.client.JerseyInvocationTest)  Time elapsed: 0.011 s  <<< FAILURE!
java.lang.AssertionError: ProcessingException expected.
	at org.glassfish.jersey.client.JerseyInvocationTest.overrideHttpMethodBasedComplianceCheckTest(JerseyInvocationTest.java:117)

This seems related to the fix. Is this a test that needs fixing or a genuine failure?

@MattGill98 MattGill98 force-pushed the AlanRoth:jersey-2.29.payara-maintenance branch 3 times, most recently from 3659b89 to a47b59a Aug 16, 2019

@MattGill98 MattGill98 force-pushed the AlanRoth:jersey-2.29.payara-maintenance branch from a47b59a to c27088d Aug 16, 2019

@MattGill98 MattGill98 merged commit d6d1972 into payara:jersey-2.29.payara-maintenance Aug 16, 2019

59 of 62 checks passed

security/snyk - examples/jersey-ejb/pom.xml (payara-ci) Test in progress
security/snyk - tests/osgi/pom.xml (payara-ci) Test in progress
security/snyk - tests/pom.xml (payara-ci) Test in progress
security/snyk - archetypes/jersey-example-java8-webapp/pom.xml (payara-ci) No new issues
Details
security/snyk - archetypes/pom.xml (payara-ci) No new issues
Details
security/snyk - bom/pom.xml (payara-ci) No new issues
Details
security/snyk - bundles/apidocs/pom.xml (payara-ci) No new issues
Details
security/snyk - connectors/grizzly-connector/pom.xml (payara-ci) No new issues
Details
security/snyk - connectors/jdk-connector/pom.xml (payara-ci) No new issues
Details
security/snyk - containers/glassfish/pom.xml (payara-ci) No new issues
Details
security/snyk - containers/grizzly2-http/pom.xml (payara-ci) No new issues
Details
security/snyk - containers/jdk-http/pom.xml (payara-ci) No new issues
Details
security/snyk - containers/jersey-servlet-core/pom.xml (payara-ci) No new issues
Details
security/snyk - containers/netty-http/pom.xml (payara-ci) No new issues
Details
security/snyk - containers/pom.xml (payara-ci) No new issues
Details
security/snyk - core-client/pom.xml (payara-ci) No new issues
Details
security/snyk - core-common/pom.xml (payara-ci) No new issues
Details
security/snyk - core-server/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/assemblies/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/bookmark/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/entity-filtering-selectable/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/extended-wadl-webapp/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/freemarker-webapp/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/helloworld-benchmark/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/helloworld-cdi2-se/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/helloworld-programmatic/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/helloworld-pure-jax-rs/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/http-patch/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/https-server-glassfish/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/json-with-padding/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/managed-beans-webapp/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/managed-client/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/multipart-webapp/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/open-tracing/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/osgi-helloworld-webapp/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/rx-client-webapp/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/server-async-managed/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/server-async-standalone/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/server-async/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/sse-item-store-jaxrs-webapp/pom.xml (payara-ci) No new issues
Details
security/snyk - examples/sse-twitter-aggregator/pom.xml (payara-ci) No new issues
Details
security/snyk - ext/cdi/pom.xml (payara-ci) No new issues
Details
security/snyk - ext/entity-filtering/pom.xml (payara-ci) No new issues
Details
security/snyk - ext/metainf-services/pom.xml (payara-ci) No new issues
Details
security/snyk - ext/mvc-mustache/pom.xml (payara-ci) No new issues
Details
security/snyk - ext/rx/pom.xml (payara-ci) No new issues
Details
security/snyk - ext/servlet-portability/pom.xml (payara-ci) No new issues
Details
security/snyk - incubator/declarative-linking/pom.xml (payara-ci) No new issues
Details
security/snyk - incubator/pom.xml (payara-ci) No new issues
Details
security/snyk - media/json-jackson1/pom.xml (payara-ci) No new issues
Details
security/snyk - media/json-processing/pom.xml (payara-ci) No new issues
Details
security/snyk - media/sse/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details
security/snyk - security/oauth1-signature/pom.xml (payara-ci) No new issues
Details
security/snyk - test-framework/maven/pom.xml (payara-ci) No new issues
Details
security/snyk - test-framework/memleak-test-common/pom.xml (payara-ci) No new issues
Details
security/snyk - test-framework/providers/pom.xml (payara-ci) No new issues
Details
security/snyk - tests/e2e-entity/pom.xml (payara-ci) No new issues
Details
security/snyk - tests/e2e-inject/pom.xml (payara-ci) No new issues
Details
security/snyk - tests/integration/pom.xml (payara-ci) No new issues
Details
security/snyk - tests/stress/pom.xml (payara-ci) No new issues
Details
security/snyk - tools/perftest-agent/pom.xml (payara-ci) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.