From 8d25e0758c2bbe2e1e68584e1a36a2ce9f1f9861 Mon Sep 17 00:00:00 2001 From: Yazal Ulloa <33322056+yazalulloa@users.noreply.github.com> Date: Fri, 22 Aug 2025 16:27:19 -0400 Subject: [PATCH 1/2] Encode cacheTag --- templates/website/src/components/Media/ImageMedia/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/website/src/components/Media/ImageMedia/index.tsx b/templates/website/src/components/Media/ImageMedia/index.tsx index 8a1dc106471..58e3c8dcbcc 100644 --- a/templates/website/src/components/Media/ImageMedia/index.tsx +++ b/templates/website/src/components/Media/ImageMedia/index.tsx @@ -42,7 +42,7 @@ export const ImageMedia: React.FC = (props) => { height = fullHeight! alt = altFromResource || '' - const cacheTag = resource.updatedAt + const cacheTag = resource.updatedAt && encodeURIComponent(resource.updatedAt) src = getMediaUrl(url, cacheTag) } From 27431171080fb20f2a10f94f6d01f9a2c9c36d74 Mon Sep 17 00:00:00 2001 From: Yazal Ulloa Date: Thu, 4 Sep 2025 13:05:42 -0400 Subject: [PATCH 2/2] move fix to getMediaUrl.ts and duplicate in vercel template --- templates/website/src/components/Media/ImageMedia/index.tsx | 2 +- templates/website/src/utilities/getMediaUrl.ts | 4 ++++ templates/with-vercel-website/src/utilities/getMediaUrl.ts | 4 ++++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/templates/website/src/components/Media/ImageMedia/index.tsx b/templates/website/src/components/Media/ImageMedia/index.tsx index 58e3c8dcbcc..8a1dc106471 100644 --- a/templates/website/src/components/Media/ImageMedia/index.tsx +++ b/templates/website/src/components/Media/ImageMedia/index.tsx @@ -42,7 +42,7 @@ export const ImageMedia: React.FC = (props) => { height = fullHeight! alt = altFromResource || '' - const cacheTag = resource.updatedAt && encodeURIComponent(resource.updatedAt) + const cacheTag = resource.updatedAt src = getMediaUrl(url, cacheTag) } diff --git a/templates/website/src/utilities/getMediaUrl.ts b/templates/website/src/utilities/getMediaUrl.ts index 7840c770ca5..f50af9130a4 100644 --- a/templates/website/src/utilities/getMediaUrl.ts +++ b/templates/website/src/utilities/getMediaUrl.ts @@ -9,6 +9,10 @@ import { getClientSideURL } from '@/utilities/getURL' export const getMediaUrl = (url: string | null | undefined, cacheTag?: string | null): string => { if (!url) return '' + if (cacheTag && cacheTag !== '') { + cacheTag = encodeURIComponent(cacheTag) + } + // Check if URL already has http/https protocol if (url.startsWith('http://') || url.startsWith('https://')) { return cacheTag ? `${url}?${cacheTag}` : url diff --git a/templates/with-vercel-website/src/utilities/getMediaUrl.ts b/templates/with-vercel-website/src/utilities/getMediaUrl.ts index 7840c770ca5..f50af9130a4 100644 --- a/templates/with-vercel-website/src/utilities/getMediaUrl.ts +++ b/templates/with-vercel-website/src/utilities/getMediaUrl.ts @@ -9,6 +9,10 @@ import { getClientSideURL } from '@/utilities/getURL' export const getMediaUrl = (url: string | null | undefined, cacheTag?: string | null): string => { if (!url) return '' + if (cacheTag && cacheTag !== '') { + cacheTag = encodeURIComponent(cacheTag) + } + // Check if URL already has http/https protocol if (url.startsWith('http://') || url.startsWith('https://')) { return cacheTag ? `${url}?${cacheTag}` : url