fix: check relationships indexed access for undefined #2278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After a change of
relationTo
in a relationship field, an existing global from before the change caused a crash in the admin UI. The whole page turned blank, and the console logged aTypeError
pointing torelationMap[relation].push
, whererelationMap[relation]
wasundefined
.TypeScript does not flag
undefined
as a possibility in these scenarios unless bothstrict
andnoUncheckedIndexedAccess
are turned on in the compiler options.I tried to add
undefined
explicitly in the type definition forRelationMap
, but it had no effect.Type of change
Checklist: