Permalink
Browse files

Bug fix for --index & --no-index issue (dependency links*)

While testing pip-accel on bigger code bases / requirement sets after
implementing the previous bug fix I noticed that it would sometimes
still slow down to a crawl. It turned out that dependency links
specified in setup.py scripts were also being followed. Fortunately the
fix is very simply based on the work done in the previous commit.
  • Loading branch information...
1 parent 85f6719 commit 9e8494b4222688c3c17c51b5c5b9d10eba36f8e1 @xolox xolox committed Feb 1, 2014
Showing with 12 additions and 3 deletions.
  1. +12 −3 pip_accel/__init__.py
View
15 pip_accel/__init__.py
@@ -20,7 +20,7 @@
"""
# Semi-standard module versioning.
-__version__ = '0.11.4'
+__version__ = '0.11.5'
# Standard library modules.
import os
@@ -440,12 +440,21 @@ class CustomPackageFinder(pip_index_module.PackageFinder):
@property
def index_urls(self):
- logger.debug("Custom package finder forcing --no-index behavior ..")
+ logger.debug("Custom package finder forcing --no-index behavior (hiding 'index_urls') ..")
return []
@index_urls.setter
def index_urls(self, value):
- pass
+ logger.debug("Custom package finder ignoring 'index_urls' value (%r) ..", value)
+
+ @property
+ def dependency_links(self):
+ logger.debug("Custom package finder forcing --no-index behavior (hiding 'dependency_links') ..")
+ return []
+
+ @dependency_links.setter
+ def dependency_links(self, value):
+ logger.debug("Custom package finder ignoring 'dependency_links' value (%r) ..", value)
if __name__ == '__main__':
main()

0 comments on commit 9e8494b

Please sign in to comment.