Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deprecate] Remove gimel-benchmarksuite and gimel-testsuite #231

Closed
anishanainani opened this issue Apr 17, 2020 · 0 comments · Fixed by #232
Closed

[Deprecate] Remove gimel-benchmarksuite and gimel-testsuite #231

anishanainani opened this issue Apr 17, 2020 · 0 comments · Fixed by #232

Comments

@anishanainani
Copy link
Contributor

What feature are your requesting?

What benefits do you foresee from the feature you are requesting?

Potential solution/ideas?

Additional context
anishanainani added a commit to anishanainani/gimel that referenced this issue Apr 17, 2020
@anishanainani
[paypal#231] Deprecate gimel-benchmarksuite and gimel-testsuite
123dc70
@anishanainani anishanainani mentioned this issue Apr 17, 2020
Merged
4 tasks
anishanainani added a commit to anishanainani/gimel that referenced this issue Apr 17, 2020
@anishanainani
[paypal#231] Deprecate gimel-benchmarksuite and gimel-testsuite
05e7312
Dee-Pac pushed a commit that referenced this issue Apr 21, 2020
@anishanainani
[#231] Deprecate gimel-benchmarksuite and gimel-testsuite (#232)
1b87047 
Make sure you have checked all steps below.

### GitHub Issue
Fixes #231 


### Checklist:
<!--- Go over all the following points. Check boxes that apply to this pull request -->
- [ ] This pull request updates the documentation
- [ ] This pull request changes library dependencies
- [ ] Title of the PR is of format (example) : [#25][Github] Add Pull Request Template

<!-- NOTE: lines that start with < - - ! and end with - - > are comments and will be ignored. -->
<!-- Please include the GitHub issue number in the PR title above. If an issue does not exist, please create one.-->
<!-- Example:[#25][Github] Add Pull Request Template where [#25 refers to #25] -->

### What is the purpose of this pull request?
<!-- Please fill in changes proposed in this pull request. -->
<!-- Example: This Pull Request upgrades codebase to spark 3.0.0  -->

### How was this change validated?
<!-- Please add the Command Used, Results Snippet, details on how reviewer/committer can simulate issue & verify the change -->
<!-- Example: In addition to unit-tests, and integration-test, I ran X on the Y cluster and verified the Z output.-->

### Commit Guidelines
- [x] My commits all reference GH issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
anishanainani added a commit to anishanainani/gimel that referenced this issue Apr 27, 2020
@anishanainani
[paypal#231] Deprecate gimel-benchmarksuite and gimel-testsuite (payp…
c5391d5 
…al#232)

Make sure you have checked all steps below.

### GitHub Issue
Fixes paypal#231 


### Checklist:
<!--- Go over all the following points. Check boxes that apply to this pull request -->
- [ ] This pull request updates the documentation
- [ ] This pull request changes library dependencies
- [ ] Title of the PR is of format (example) : [paypal#25][Github] Add Pull Request Template

<!-- NOTE: lines that start with < - - ! and end with - - > are comments and will be ignored. -->
<!-- Please include the GitHub issue number in the PR title above. If an issue does not exist, please create one.-->
<!-- Example:[paypal#25][Github] Add Pull Request Template where [paypal#25 refers to paypal#25] -->

### What is the purpose of this pull request?
<!-- Please fill in changes proposed in this pull request. -->
<!-- Example: This Pull Request upgrades codebase to spark 3.0.0  -->

### How was this change validated?
<!-- Please add the Command Used, Results Snippet, details on how reviewer/committer can simulate issue & verify the change -->
<!-- Example: In addition to unit-tests, and integration-test, I ran X on the Y cluster and verified the Z output.-->

### Commit Guidelines
- [x] My commits all reference GH issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#231] Deprecate gimel-benchmarksuite and gimel-testsuite anishanainani/gimel
1 participant
@anishanainani