Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against falsy render param value for 'funding.allowed' #1007

Conversation

dechov
Copy link

@dechov dechov commented Feb 4, 2019

Fixes https://github.com/paypal/paypal-checkout/issues/1006

Guards against falsy values (e.g. null) passed as the funding.allowed parameter in the Button render code (similar to how allowed is checked for 16 lines above), to avoid breaking the render.

@mcntsh
Copy link
Contributor

mcntsh commented Feb 4, 2019

Thanks @dechov for your PR. This bug is a P1 impacting several merchants so we went ahead and filed our own which addresses a couple of other use-cases:

  1. All non-array values (not just falsy)
  2. Disallowed list as well as Allowed.

We really appreciate your report and your quick PR. This fix will be out in the next hour.

@mcntsh mcntsh closed this Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants