fix(error-focus-closed): Catching the error from the promise #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 22, 2018 16:32
If `actions.focus()` throws an error, we can assume something is wrong and close the window.
…to fix/error-focus-closed * 'master' of https://github.com/paypal/paypal-checkout: 4.0.229 Dist fix(callback-api-decorator): Fixing bug where onShippingChange prop was being passed up to parent when it wasnt defined (paypal#918) fix(callback-api): Call onError when the prop catches an error (paypal#908) fix(callback-api): Adding in `actions.resolve` to shipping change callback (paypal#912) style(card-demo): Cleaning up the card demo (paypal#904) feat(vue-demo): Adding vue2 integration demo (paypal#905) fix(error-focus-closed): Remove error when focusing on closed window (paypal#906)
|
I think we'd need to make sure |
|
In zoid, |
…to fix/error-focus-closed * 'master' of https://github.com/paypal/paypal-checkout: 4.0.231 Dist Flush remembered funding after determining all sources 4.0.230 Dist fix debounce function on click (paypal#927) xcomponent to zoid cleanup Revert " feat(a11y-trap-tab): Trapping tab gestures in parent window while popup is enabled (paypal#896)" Updating Venmo Blacklist (paypal#926) Add university tees to blacklist Remove top pay button experiment Switch to zoid reverting bml test code (paypal#917)
mcntsh
force-pushed
the
fix/error-focus-closed
branch
from
f7e3c98
to
fe31987
Compare
mcntsh
force-pushed
the
fix/error-focus-closed
branch
from
fe31987
to
b8e6d38
Compare
|
@bluepnume I ended up using |
bluepnume
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try { ... } catch ...doesn't work for these cross-domain functions. Doh.