Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
I have find a Reflected XSS vulnerability in this sdk #19
The vulnerability exists due to insufficient filtration of user-supplied data in “verification_code” HTTP REQUEST parameter that will be passed to “permissions-sdk-php-master\samples\GetAccessToken.php”. The infected source code is line 24, there is no protection on$_REQUEST['verification_code']; if $_REQUEST['verification_code'] contains evil js code, line 24 will trigger untrusted code to be excuted on the browser side.
So if a attacker construct a special url as follow and send it to a victim, when the victim click the url, the code which is contained in the url will be executed on the victim's browser side to do some evil.
Discoverer: ADLab of Venustech
referenced this issue
Mar 29, 2017
Hey @jgj212 !
As discussed in your PR, the samples are for training purposes only, and out intention is to keep it simple to understand the API process. It is expected from developers to use their due diligance on implementing these samples in real life.
However, we were able to add a layer of protection by discarding