Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upsolarized_dark: improve 256 color approximation #550
Merged
Conversation
Solarized colors for 256 color palettes are not as closely approximated as they could be. 256_base0 is set to g66 in Urwid's 256 color palette. This corresponds to #a8a8a8 in Xterm. base0 should ideally be #808080. This matches g50 exactly, so switch to that grayscale value. 256_base1 is set to g70 in Urwid's 256 color palette. This corresponds to #b2b2b2 in Xterm. base1 should ideally be #8a8a8a. We can't get this exactly with Urwid's 256 color palette, but #848484 is a closer approximation. Switch to g52 to get this grayscale value. 256_cyan is set to #88 in Urwid's 256 color palette. This corresponds to #008787 in Xterm. cyan should ideally be #00afaf. This matches #0aa exactly, so switch to that value. Signed-off-by: Michael Turquette <mturquette@deferred.io>
This comment has been minimized.
This comment has been minimized.
pazz
commented on dd327e0
Jan 8, 2013
|
ah yes. I think i actually deliberately changed this value because somehow, #0aa looks not very solarized-like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mturquette commentedJan 8, 2013
Solarized colors for 256 color palettes are not as closely approximated
as they could be.
256_base0 is set to g66 in Urwid's 256 color palette. This corresponds
to #a8a8a8 in Xterm. base0 should ideally be #808080. This matches g50
exactly, so switch to that grayscale value.
256_base1 is set to g70 in Urwid's 256 color palette. This corresponds
to #b2b2b2 in Xterm. base1 should ideally be #8a8a8a. We can't get
this exactly with Urwid's 256 color palette, but #848484 is a closer
approximation. Switch to g52 to get this grayscale value.
256_cyan is set to #88 in Urwid's 256 color palette. This corresponds
to #008787 in Xterm. cyan should ideally be #00afaf. This matches #0aa
exactly, so switch to that value.
Signed-off-by: Michael Turquette mturquette@deferred.io