solarized_dark: improve 256 color approximation #550

Merged
merged 1 commit into from Jan 8, 2013

Conversation

2 participants
@mturquette
Contributor

mturquette commented Jan 8, 2013

Solarized colors for 256 color palettes are not as closely approximated
as they could be.

256_base0 is set to g66 in Urwid's 256 color palette. This corresponds
to #a8a8a8 in Xterm. base0 should ideally be #808080. This matches g50
exactly, so switch to that grayscale value.

256_base1 is set to g70 in Urwid's 256 color palette. This corresponds
to #b2b2b2 in Xterm. base1 should ideally be #8a8a8a. We can't get
this exactly with Urwid's 256 color palette, but #848484 is a closer
approximation. Switch to g52 to get this grayscale value.

256_cyan is set to #88 in Urwid's 256 color palette. This corresponds
to #008787 in Xterm. cyan should ideally be #00afaf. This matches #0aa
exactly, so switch to that value.

Signed-off-by: Michael Turquette mturquette@deferred.io

solarized_dark: improve 256 color approximation
Solarized colors for 256 color palettes are not as closely approximated
as they could be.

256_base0 is set to g66 in Urwid's 256 color palette.  This corresponds
to #a8a8a8 in Xterm.  base0 should ideally be #808080.  This matches g50
exactly, so switch to that grayscale value.

256_base1 is set to g70 in Urwid's 256 color palette.  This corresponds
to #b2b2b2 in Xterm.  base1 should ideally be #8a8a8a.  We can't get
this exactly with Urwid's 256 color palette, but #848484 is a closer
approximation.  Switch to g52 to get this grayscale value.

256_cyan is set to #88 in Urwid's 256 color palette.  This corresponds
to #008787 in Xterm.  cyan should ideally be #00afaf.  This matches #0aa
exactly, so switch to that value.

Signed-off-by: Michael Turquette <mturquette@deferred.io>
@pazz

This comment has been minimized.

Show comment
Hide comment
@pazz

pazz Jan 8, 2013

ah yes. I think i actually deliberately changed this value because somehow, #0aa looks not very solarized-like
in the bright theme and i wanted to use colours consistently.
But i have no strong feelings either way and will push this anyway. thanks.

pazz commented on dd327e0 Jan 8, 2013

ah yes. I think i actually deliberately changed this value because somehow, #0aa looks not very solarized-like
in the bright theme and i wanted to use colours consistently.
But i have no strong feelings either way and will push this anyway. thanks.

@pazz pazz merged commit dd327e0 into pazz:master Jan 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment