New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version numbers missing on macOS #1038

Closed
core-code opened this Issue Oct 1, 2018 · 17 comments

Comments

Projects
None yet
2 participants
@core-code

core-code commented Oct 1, 2018

i've downloaded Version '18.09.5' but when selecting it in the Finder and using 'Get Info' it doesn't show any Version-number at all. i guess the CFBundleVersion and CFBundleShortVersionString entries in your Info.plist file are missing.
all apps on macOS are supposed to contain valid version information.

@pbek pbek added the enhancement label Oct 2, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Oct 2, 2018

I guess I never did that, thank you for letting me know.
Is there is a smart way of integrating it into https://github.com/pbek/QOwnNotes/blob/develop/.travis.yml or https://github.com/pbek/QOwnNotes/blob/develop/travis/create-dmg.sh?

@core-code

This comment has been minimized.

core-code commented Oct 2, 2018

since the version seems to be available as
$VERSION_NUMBER
in
create-dmg.sh

i guess adding

/usr/libexec/PlistBuddy -c "Set :CFBundleVersion $VERSION_NUMBER" $APP.app/Contents/Info.plist
/usr/libexec/PlistBuddy -c "Set :CFBundleShortVersionString $VERSION_NUMBER" $APP.app/Contents/Info.plist

around line 22 could do the trick

sorry no idea about travis

@pbek

This comment has been minimized.

Owner

pbek commented Oct 2, 2018

Thank you, I'll try that for the next release.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 3, 2018

I added the commands to https://github.com/pbek/QOwnNotes/blob/develop/travis/create-dmg.sh.

But in https://travis-ci.org/pbek/QOwnNotes/jobs/436312295 the two lines threw:

Set: Entry, ":CFBundleVersion", Does Not Exist
Set: Entry, ":CFBundleShortVersionString", Does Not Exist
@pbek

This comment has been minimized.

Owner

pbek commented Oct 3, 2018

I now used

/usr/libexec/PlistBuddy -c "Add :CFBundleVersion string $VERSION_NUMBER" $APP.app/Contents/Info.plist
/usr/libexec/PlistBuddy -c "Add :CFBundleShortVersionString string $VERSION_NUMBER" $APP.app/Contents/Info.plist

The information is now set in the plist file, but finder doesn't seem to show me a version number when right clicking on the app and pressing Information. Where should the information show up?

@pbek

This comment has been minimized.

@core-code

This comment has been minimized.

core-code commented Oct 3, 2018

hello again. ah yes, sorry the right syntax if the key doesn't exist is to use 'Add' and not 'Set'.

i can confirm that QOwnNotesDev-ea90db58306f18067c64e9679e60547375e1f750 now contains proper version numbers but i still don't see it in the Finder either, because the version is 'overwritten' by this:

<key>CFBundleGetInfoString</key>
<string>Created by Qt/QMake</string

since this key has been deprecated for more than 10 years i guess it should just be removed. the version should show up in the Finder then

@pbek

This comment has been minimized.

Owner

pbek commented Oct 3, 2018

I have now integrated /usr/libexec/PlistBuddy -c "Delete :CFBundleGetInfoString" $PLIST too.

@pbek pbek added this to the 18.10.0 milestone Oct 3, 2018

@core-code

This comment has been minimized.

core-code commented Oct 3, 2018

perfect, thanks

@pbek

This comment has been minimized.

Owner

pbek commented Oct 3, 2018

You will be able to test it as soon as TravisCI will upload the dmg to https://github.com/pbek/QOwnNotes/releases.

@core-code

This comment has been minimized.

core-code commented Oct 3, 2018

dev-macosx-b3854-141807 looks good ;) i think we can close this, thanks

@pbek

This comment has been minimized.

Owner

pbek commented Oct 3, 2018

Thank you for testing! It will be in the next official release.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 5, 2018

There now is a new release, could you please test it and report if it works for you?

@core-code

This comment has been minimized.

core-code commented Oct 5, 2018

i assume you are talking about the 18.10.0 release but i am unable to find a (mac) download on both github and the website

@pbek

This comment has been minimized.

Owner

pbek commented Oct 5, 2018

patience, patience :)
will need some time: https://travis-ci.org/pbek/QOwnNotes/jobs/437570363

@core-code

This comment has been minimized.

core-code commented Oct 5, 2018

thanks i can confirm all is well now ;)

@core-code core-code closed this Oct 5, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Oct 5, 2018

Great, thank you for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment