New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from evernote ENEX format does not handle code blocks #1047

Closed
Gazoo opened this Issue Oct 21, 2018 · 17 comments

Comments

Projects
None yet
2 participants
@Gazoo

Gazoo commented Oct 21, 2018

Expected behaviour

When importing notes from Evernote ENEX format code blocks should be wrapped within markdown code tags ```.

Actual behaviour

Code blocks are not wrapped in markdown code tags ``` .

Steps to reproduce

Export note into ENEX format from evernote.

Operating system

WIndows 10, using QOwnNotes version 18.10.4 build 3899
![evernote]

Screens

Evernote
evernote

After Import
after import

@pbek pbek added the enhancement label Oct 21, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Oct 21, 2018

Thank you for your suggestion.
Could you please post an enex file with a code block.

@Gazoo

This comment has been minimized.

Gazoo commented Oct 21, 2018

Here is a test enex I exported that contains a code block. I had to zip it up as github doesn't allow attaching .enex files.

test.zip

@pbek

This comment has been minimized.

Owner

pbek commented Oct 21, 2018

Thank you!

@pbek

This comment has been minimized.

Owner

pbek commented Oct 24, 2018

It was a bit tricky, but I think I've got it working now (without regressions).

18.10.5

  • the Evernote importer is now able to import code blocks

pbek added a commit that referenced this issue Oct 24, 2018

@Gazoo

This comment has been minimized.

Gazoo commented Oct 24, 2018

Thanks man!

@Gazoo Gazoo closed this Oct 24, 2018

@pbek pbek reopened this Oct 24, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Oct 24, 2018

There now is a new release, could you please test it and report if it works for you (when the build is done)?

@Gazoo

This comment has been minimized.

Gazoo commented Oct 24, 2018

Sure thing. I'll update this with my results.

@Gazoo

This comment has been minimized.

Gazoo commented Oct 24, 2018

Unfortunately they still don't import properly. I'm including the sample note.

Evernote Note
evernote

After Import
import

Sample ENEX used.
Colorized grep.zip

@pbek

This comment has been minimized.

Owner

pbek commented Oct 24, 2018

It worked with your previous example and an other I found. I'll take a look. But I cannot promise a lot, the syntax for code blocks in the enex file is very wonky.

pbek added a commit that referenced this issue Oct 28, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Oct 28, 2018

phew, took quite some time...

18.10.6

  • improved code block import of the Evernote importer
    • some other issues were also fixes
@pbek

This comment has been minimized.

Owner

pbek commented Oct 28, 2018

There now is a new release, could you please test it and report if it works for you?

@Gazoo

This comment has been minimized.

Gazoo commented Oct 29, 2018

Sorry man still doesn't import properly. I suggest that you might want to just give up on this one :(

Evernote
2018-10-29_10h19_00

After Import
2018-10-29_10h18_50

Enex file
Evernote.zip

@pbek

This comment has been minimized.

Owner

pbek commented Oct 29, 2018

I'll check the new examples... ;)

@pbek

This comment has been minimized.

Owner

pbek commented Oct 31, 2018

Your latest example uses a slightly other notation for code blocks, I integrated that one too now.

18.11.0

  • improved code block import of the Evernote importer

@pbek pbek added this to the 18.11.0 milestone Oct 31, 2018

pbek added a commit that referenced this issue Oct 31, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Nov 1, 2018

There now is a new release, could you please test it and report if it works for you?

@Gazoo

This comment has been minimized.

Gazoo commented Nov 2, 2018

The new release fixed it. My notes import properly now :) Thanks man!

@Gazoo Gazoo closed this Nov 2, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Nov 2, 2018

Finally! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment