Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folders should list all nested notes, no matter the nesting depth (IMHO) #1206

Closed
danbohea opened this issue May 18, 2019 · 6 comments

Comments

Projects
None yet
2 participants
@danbohea
Copy link

commented May 18, 2019

Expected behaviour

Selecting a folder that contains further subfolders of notes should list all of the notes, no matter how deeply nested. Also, the note count beside the folder should be calculated from the sum of all nested notes.

IMHO this would be much more useful than the current behaviour which misses much of the benefit of being able to nest folders. If my preference is considered divisive then perhaps we could consider a config option to set it one way or the other.

Actual behaviour

Only the notes that are stored within the selected folder are listed. Notes that are more deeply nested are not listed. The note count beside the folder is based only on the notes stored directly within that folder.

Parent folder selected

Subfolder selected

@pbek pbek added the question label May 18, 2019

@pbek

This comment has been minimized.

Copy link
Owner

commented May 18, 2019

Selecting a folder that contains further subfolders of notes should list all of the notes, no matter how deeply nested.

Are you talking about the "Show all notes in a folder..." checkbox in the Panels settings?

@danbohea

This comment has been minimized.

Copy link
Author

commented May 18, 2019

Aha, yes! That solves most of the issue for me - thank you, I hadn't spotted that.

The note count beside each folder in the folders panel is still misleading to me though. Perhaps the setting you mentioned could also toggle how note count is calculated?

@pbek

This comment has been minimized.

Copy link
Owner

commented May 19, 2019

19.5.3

  • if the setting Show all notes in a folder including their subfolders is
    activated now the note-subfolder list will show the note count recursively for
    all children note-subfolders

@pbek pbek added this to the 19.5.3 milestone May 19, 2019

@pbek pbek added the enhancement label May 19, 2019

pbek added a commit that referenced this issue May 19, 2019

@pbek

This comment has been minimized.

Copy link
Owner

commented May 19, 2019

There now is a new release, could you please test it and report if it works for you?

@danbohea

This comment has been minimized.

Copy link
Author

commented May 19, 2019

Just tested and am pleased to say that it appears to work really well :)

Once again, thank you for your time & effort!

@pbek

This comment has been minimized.

Copy link
Owner

commented May 19, 2019

Great, thank you for testing! 😄

@pbek pbek closed this May 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.