Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for macOS dark mode #1209

Closed
janprzy opened this issue May 25, 2019 · 18 comments

Comments

Projects
None yet
2 participants
@janprzy
Copy link

commented May 25, 2019

Are there any plans to support the dark mode added in macOS Mojave? I know the app has its own dark mode, but, for example, the title bar and popups are still using the light theme, which looks weird when the rest of the system is dark.

@janprzy janprzy changed the title Support for macOS darkmode Support for macOS dark mode May 25, 2019

@pbek

This comment has been minimized.

Copy link
Owner

commented May 26, 2019

I don't know about your setup (since you didn't post it) or how QOwnNotes looks on your system (a screenshot would do wonder), but did you already play around with the script Custom user interface styling? You could set colors there and then let me know if you were able to set the missing colors.

@pbek

This comment has been minimized.

Copy link
Owner

commented May 26, 2019

And I read something about adding two lines to the Info.plist file for the title bar:

<key>NSRequiresAquaSystemAppearance</key>
<string>false</string>
@janprzy

This comment has been minimized.

Copy link
Author

commented May 26, 2019

By default it looks like this

Dark mode disabled

Default

This is what QOwnNotes own dark mode looks like

Note that the title bar is still bright
Dark

File selector

Bildschirmfoto 2019-05-26 um 12 20 11

After making the changes to Info.plist

Default

It is actually using the system's dark mode now (look at the title bar). However, the toolbar icons are still light grey. This is exactly the same as Issue #1177
system dark mode

File selector

Bildschirmfoto 2019-05-26 um 12 20 52

Own dark mode

dark2

Something else I noticed: When the app's internal dark mode is enabled, it does not use the system's checkboxes, buttons etc.:
Bildschirmfoto 2019-05-26 um 12 12 57
Bildschirmfoto 2019-05-26 um 12 13 23

About screen

Bildschirmfoto 2019-05-26 um 11 42 00

According to this website, apps need to be built against the macOS 10.14 SDK to support dark mode. If I understand correctly, Qt supports it since version 5.12.

@pbek

This comment has been minimized.

Copy link
Owner

commented May 26, 2019

Thank you for your feedback. Unfortunately Travis-CI still uses the 10.13 SDK according to https://docs.travis-ci.com/user/reference/osx#macos-version

@janprzy

This comment has been minimized.

Copy link
Author

commented May 26, 2019

You can use another version of macOS (and Xcode) by specifying the corresponding osx_image key from the following table

@pbek

This comment has been minimized.

Copy link
Owner

commented May 27, 2019

@janprzy

This comment has been minimized.

Copy link
Author

commented May 27, 2019

You accidentally sent the link to build 4264 instead of 4265.
I downloaded and tried 4265, it's using the system's dark mode correctly now, thanks!
The only problem is that now the icons are dark gray on a slightly darker background, exactly like Issue #1177 (see the 4th screenshot in my previous comment, that's exactly what it looks like now.

@pbek

This comment has been minimized.

Copy link
Owner

commented May 27, 2019

Sorry for the confusion and thank you for testing. Do you also have turned on the QOwnNotes dark mode?

@pbek

This comment has been minimized.

Copy link
Owner

commented May 28, 2019

For me everything seems to be fine:

Bildschirmfoto 2019-05-28 um 05 45 16

@janprzy

This comment has been minimized.

Copy link
Author

commented May 30, 2019

If I turn on QOwnNotes dark mode, it looks like it does in your screenshot.
If you turn it off, you should also get the problem with the icons.

@pbek

This comment has been minimized.

Copy link
Owner

commented May 31, 2019

If I turn on QOwnNotes dark mode, it looks like it does in your screenshot.

so is there still a problem for you?

If you turn it off, you should also get the problem with the icons.

which one? the ones in the toolbar? which problem and why do you want to turn dark mode off?

@janprzy

This comment has been minimized.

Copy link
Author

commented May 31, 2019

which one? the ones in the toolbar?

Yes, exactly. They're light gray on a dark gray background:
system dark mode

Like I said, it's exactly like issue #1177. Despite using a dark system theme, the default icons are used. This should be solvable in the same way:

Changed in 19.4.2:

for Linux there there now is a setting in the Interface settings to enforce
the system icon theme in case your desktop environment doesn't report the icon
theme correctly

I think enabling this on macOS too should do the trick.

why do you want to turn dark mode off?

There's a difference between QOwnNotes' own dark mode and the system dark mode (which is used when the native one is turned off)
Native:
Bildschirmfoto 2019-05-26 um 12 13 23

System:
Bildschirmfoto 2019-05-26 um 12 12 57

@pbek

This comment has been minimized.

Copy link
Owner

commented May 31, 2019

#1177 is different because KDE uses free desktop theme icons that QOwnNotes can use and macOS does not have that. I have no way to detect in what mode macOS is running.

pbek added a commit that referenced this issue Jun 2, 2019

@pbek

This comment has been minimized.

Copy link
Owner

commented Jun 2, 2019

19.6.0

  • You are now able to distinctively tell QOwnNotes to use the dark mode icon theme
    without using the dark mode in the Interface settings

@pbek pbek added this to the 19.6.0 milestone Jun 2, 2019

@pbek

This comment has been minimized.

Copy link
Owner

commented Jun 2, 2019

There now is a new release, could you please test it and report if it works for you?

@janprzy

This comment has been minimized.

Copy link
Author

commented Jun 2, 2019

It works now, that's exactly what I was talking about. Thank you for your patience and keep on the great work!

Bildschirmfoto 2019-06-02 um 10 35 32

@janprzy janprzy closed this Jun 2, 2019

@pbek

This comment has been minimized.

Copy link
Owner

commented Jun 2, 2019

Great, thank you for testing! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.