Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu icon & text overlap for menu with checkbox in dark mode #1221

Closed
zmni opened this issue Jun 22, 2019 · 10 comments

Comments

Projects
None yet
2 participants
@zmni
Copy link

commented Jun 22, 2019

OS: Windows 8.1 (6.3). Version: 19.6.4. Build: 4332

Actual behaviour

Overlaping icon & text.

a
b
c

@pbek

This comment has been minimized.

Copy link
Owner

commented Jun 22, 2019

Thank you for reporting, but I can't reproduce that on Windows 10 in German/English.

Can you please post the output from the debug settings (see issue template).

@pbek

This comment has been minimized.

Copy link
Owner

commented Jun 22, 2019

Did you have that problem on previous versions of QOwnNotes?

@zmni

This comment has been minimized.

Copy link
Author

commented Jun 22, 2019

Debug information is on GitHub Gist.

No, I don't have this issue. I don't remember which version I previously installed, but it's old. It works for me, so I always skip the updates.

@pbek

This comment has been minimized.

Copy link
Owner

commented Jun 22, 2019

No problem here...

image

But I also get the problem in dark mode on Windows 10.

@pbek pbek changed the title Menu icon & text overlap for menu with checkbox Menu icon & text overlap for menu with checkbox on Windows in dark mode Jun 22, 2019

@zmni

This comment has been minimized.

Copy link
Author

commented Jun 22, 2019

Yeah, ditto. Apparently the problem occurred when dark mode was active. I disable dark mode and the problem is gone.

@pbek pbek changed the title Menu icon & text overlap for menu with checkbox on Windows in dark mode Menu icon & text overlap for menu with checkbox in dark mode Jun 22, 2019

@pbek

This comment has been minimized.

Copy link
Owner

commented Jun 23, 2019

19.6.5

  • fixed icon-text-overlap for checkboxes and radio groups in the main menu in dark mode

@pbek pbek added this to the 19.6.5 milestone Jun 23, 2019

@pbek

This comment has been minimized.

Copy link
Owner

commented Jun 23, 2019

The icon positioning seems to be handled differently on newer Qt versions...

@pbek

This comment has been minimized.

Copy link
Owner

commented Jun 23, 2019

There now is a new release, could you please test it and report if it works for you?

@zmni

This comment has been minimized.

Copy link
Author

commented Jun 23, 2019

Yes, no issue now. No more overlap.

Thank you.

@zmni zmni closed this Jun 23, 2019

@pbek

This comment has been minimized.

Copy link
Owner

commented Jun 23, 2019

Great, thank you for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.