Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Enable editing when sharing Nextcloud links #1280

Closed
MathiasRenner opened this issue Sep 4, 2019 · 19 comments

Comments

@MathiasRenner
Copy link

commented Sep 4, 2019

Earlier this year, Nextcloud included a web-based text editor that allows parallel text editing for multiple users in real time.

To allow the editing functionality in Nextcloud, you activate a checkbox saying "allowing editing":
image

QOwnNotes already allows to share documents. What about extending this feature (see following screenshot) with a checkbox "allow editing"?

image

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 4, 2019

Seems like a good idea.

Where can I find this checkbox and what exactly does it do? I don't seem to have it on my 16.0.4 NC installation.

Is there an api documentation for it?

@pbek pbek added the enhancement label Sep 4, 2019

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 4, 2019

Are we talking about Nextcloud text? (like in #1226)

@MathiasRenner

This comment has been minimized.

Copy link
Author

commented Sep 4, 2019

Yep, this is Nextcloud Text as in the issue you referenced.
This is an add-on you have to install in NC.
With next version 17 (will be released probably this week) or 18, it will be included in the base installation.

I haven't check API docu yet.

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 4, 2019

I have Nextcloud Text installed but I can't see the menu item

@MathiasRenner

This comment has been minimized.

Copy link
Author

commented Sep 4, 2019

Hmm, it only works on text-based files - did you try it on .md and .txt ?

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 4, 2019

Hmm, it only works on text-based files - did you try it on .md and .txt ?

yes, I tried it on my notes... I can edit them with NC Text when left-clicking them in the Files app. But I don't see the checkbox and I have no idea what it might do.

@leander091

This comment has been minimized.

Copy link

commented Sep 5, 2019

The option to enable editing on a text file is a part of the share menu. You will need to create a shared link before getting the menu to enable editing. Like this:
image

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 5, 2019

Ah, thank you @leander091! It used a PUT request to an url like https://server/ocs/v2.php/apps/files_sharing/api/v1/shares/1111?format=json. Can it be used externally too (no cors) and do you know if there is a documentation for it?

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 5, 2019

Too bad that it seems editing the shared file without logging in causes the current version to be overwritten without creating a new version. So basically it looks like I edited the file myself instead of someone else edited it...

pbek added a commit that referenced this issue Sep 6, 2019
pbek added a commit that referenced this issue Sep 6, 2019
pbek added a commit that referenced this issue Sep 6, 2019
@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 6, 2019

tricky, tricky... 😸

19.9.4

  • you can now allow note editing when sharing notes on your Nextcloud
    server with the share dialog
    • the person who receives the share link will then be able to edit your note
      with Nextcloud Text

@pbek pbek added this to the 19.9.4 milestone Sep 6, 2019

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 6, 2019

There now is a new release, could you please test it and report if it works for you?

And could you also please (if you care to) test the image support from #1226, there was a regression I now fixed...

@MathiasRenner

This comment has been minimized.

Copy link
Author

commented Sep 6, 2019

@pbek Wow, you are awesome. I successfully tested it. It works as I expected, I have NC 16.04. Thank you so much!!

There's only one bug missing. When I remove the checkbox for sharing, I get this error:
image

@leander091

This comment has been minimized.

Copy link

commented Sep 6, 2019

Nice :), it works as expected. Also the image support in #1226 works pretty well :).

I can also confirm the issue when removing the allow editing checkbox.

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 6, 2019

Thank you for testing! :) I'll take a look at the error, was in introduced with this release?

@MathiasRenner

This comment has been minimized.

Copy link
Author

commented Sep 7, 2019

@pbek Nice, thanks! I don't know if this error has been introduced with this release, sorry...

pbek added a commit that referenced this issue Sep 7, 2019
@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 7, 2019

19.9.5

  • fixed incorrect note share status update

@pbek pbek modified the milestones: 19.9.4, 19.9.5 Sep 7, 2019

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 7, 2019

There now is a new release, could you please test it and report if it works for you?

@MathiasRenner

This comment has been minimized.

Copy link
Author

commented Sep 7, 2019

@pbek It works, nice! I like your super low response time... Good work! I'll definitely make sure my donations will at least stay on the same leve as of now :-)

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 7, 2019

Thanks a lot! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.