Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images linked from web not showing in preview pane #1286

Closed
bipox opened this issue Sep 9, 2019 · 8 comments

Comments

@bipox
Copy link

commented Sep 9, 2019

Images stored on computer are shown correctly, but anything linked from the web just shows an empty white file icon in the preview.

Here is the error message:
[19:25:17] [warning] QString::replace: invalid QRegularExpression object

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 9, 2019

Thank you for reporting, I guess that will be a side effect from #266. I will look into it.

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 9, 2019

Note: Support for remote images was implemented recently in #1244.

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 9, 2019

@bipox, meanwhile you could test the new image dialog (release 19.9.6, currently building) from #1285 that also uses the new image link format (see #266).

@pbek pbek added this to the 19.9.7 milestone Sep 10, 2019

pbek added a commit that referenced this issue Sep 10, 2019
@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2019

19.9.7

  • fixed preview of remote images
@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2019

There now is a new release, could you please test it and report if it works for you?

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2019

I guess your comment in #1285 meant that it is fixed, right? 😄

@pbek pbek closed this Sep 10, 2019

@bipox

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

Yes 😄

@pbek

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2019

Thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.