New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to note with multibyte character title #144

Closed
piyo-gh opened this Issue Apr 15, 2016 · 18 comments

Comments

Projects
None yet
2 participants
@piyo-gh

piyo-gh commented Apr 15, 2016

Currently link to note doesn't support multibyte character title.
For example, any 3 character title like 'テスト' or 'ノート' become the same '<note://___>'.

Is there any plan to support in future version ?
Thanks,

@pbek

This comment has been minimized.

Owner

pbek commented Apr 15, 2016

I will look into that.

@pbek pbek added the enhancement label Apr 15, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Apr 15, 2016

@piyo-gh, in case you want to help translating QOwnNotes into your wonderful language (I boldly assume you are Japanese) you can do so at: https://crowdin.com/project/qownnotes/invite
I'd really love to add Japanese as new language to QOwnNotes, since I love the Japanese culture so much. 🙇

@piyo-gh

This comment has been minimized.

piyo-gh commented Apr 16, 2016

Ok, translation is done.

@pbek

This comment has been minimized.

Owner

pbek commented Apr 16, 2016

Three words... You Are Amazing! Thank you so much. I will integrate it into today's release!

@pbek pbek added this to the 1.4.3 milestone Apr 16, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Apr 16, 2016

I found a solution to support such links! It will be integrated into version 1.4.3.
Links like <note://テスト> can be generated and will be interpreted correctly. Can you please test this and report back when v1.4.3 is out?

@pbek

This comment has been minimized.

Owner

pbek commented Apr 16, 2016

Version 1.4.3 is now released.

@piyo-gh

This comment has been minimized.

piyo-gh commented Apr 16, 2016

First of all, I appreciate for your work.
Most of the cases, link to note works fine without problem or with small adjustment.
It's great, even though it may not perfect.
Thank you very much. :)

One thing that I felt strange is full width numbers.

  • Make a new note titled '4月16日'.
  • Insert a link to this page with link dialog. ( <note://4月16日> )

Above step is perfect but ...

  • Click this link on preview panel.

Nothing happens. But instead <note://_月__日> can jump.

@pbek

This comment has been minimized.

Owner

pbek commented Apr 16, 2016

It seems that somehow the full with numbers get translated to "normal" numbers by Qt, I'm not sure yet if I can fix that... :/

@piyo-gh

This comment has been minimized.

piyo-gh commented Apr 16, 2016

Thank you for your explaining.

In that case, it is Ok. This was just a test.
I usually don't use full width numbers, so this is not a problem for me.

Now, I will close this issue. Thank you very much for your time.

@piyo-gh piyo-gh closed this Apr 16, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Apr 17, 2016

Last night I was thinking of a workaround. I will test my idea today... Maybe I can do something about it. 😸

@pbek

This comment has been minimized.

Owner

pbek commented Apr 17, 2016

In version 16.04.12 I added support for full width numbers in note names when linking notes with unicode characters! Can you please test it when it is release?

@pbek pbek reopened this Apr 17, 2016

@piyo-gh

This comment has been minimized.

piyo-gh commented Apr 17, 2016

Thank you for trying.
But unfortunatelly, it doesn't work as expected.

  • I made 4 notes.

一月 (chinese numeral)
2月 (full width)
3月 (full width)
五月 (chinese numeral)

  • And I made 7 links to notes and clicked. 4月 (digit) and 七月 (chinese numeral) are invalid links.

<note://一月> 一月 was opened (correct)

<note://2月> 一月 was opened (wrong)

<note://3月> 一月 was opened (wrong)

<note://4月> 一月 was opened (wrong)

<note://五月> 五月 was opened (correct)

<note://6月> 一月 was opened (wrong)

<note://七月> no note was opened (correct)

@pbek

This comment has been minimized.

Owner

pbek commented Apr 17, 2016

The workaround for the number problem was to enter a wildcard character instead of the numbers if unicode characters where used. That's why other notes can be found...

Can you please write down all full width numbers for me. What does represent? 0?

@pbek

This comment has been minimized.

Owner

pbek commented Apr 17, 2016

I gave it an other hour, but then I realised Qt doesn't support version 3 (with regular expressions) of SQLite. I fear I can't make a workaround for this QTextEdit behaviour... I will close this issue until I find an other solution.

@pbek pbek closed this Apr 17, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Apr 17, 2016

I really found an other way to deal with it.
These notes will now be recognized correctly.

<note://4月16日>
<note://6月16日>

I will try and make you a new release tomorrow. Can you please test it then?

@pbek pbek reopened this Apr 17, 2016

@pbek pbek modified the milestones: 1.4.3, 16.04.13 Apr 18, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Apr 18, 2016

Version 16.04.13 is out now. 🎉

@piyo-gh

This comment has been minimized.

piyo-gh commented Apr 18, 2016

Yes, it works, thank you.
This workaround is enough for me.

@piyo-gh piyo-gh closed this Apr 18, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Apr 18, 2016

great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment