New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After typing in folder search field all folders are expanded #254

Closed
LightTemplar opened this Issue Jul 17, 2016 · 12 comments

Comments

Projects
None yet
2 participants
@LightTemplar

LightTemplar commented Jul 17, 2016

I tested the new feature "you can now also create a note subfolder by typing it into the search field and pressing Return".

Typed "test", pressed "Return", and watched all folders in folder tree stayed expanded.

@pbek

This comment has been minimized.

Owner

pbek commented Jul 17, 2016

Thank you for reporting, what do you mean by watched all folders in folder tree stayed expanded? And was the folder created?

@LightTemplar

This comment has been minimized.

LightTemplar commented Jul 17, 2016

The folder was created, there was no problem.
Problem is, I have hundred subfolders under Root, which are all (didn't check whether really all, but indeed most of them ) got expanded.

@LightTemplar LightTemplar changed the title from After typing in folder search field all folder are expanded to After typing in folder search field all folders are expanded Jul 18, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Jul 20, 2016

This field is also for searching, if you type characters that is matching a folder name it will be viewed. Of course then that sub-tree needs to be expanded.

I don't see a way to get around this.

@pbek pbek closed this Jul 20, 2016

@LightTemplar

This comment has been minimized.

LightTemplar commented Jul 20, 2016

You can turn off the remembering of node states, while someone search the folder. As soon this field is emptied, you can restore the state.
Or, if you do it different, you can remember the nodes states, before the search begins, i.e. as soon the first character is entered in the field. And as soon the field is emptied, you can restore the state

@pbek

This comment has been minimized.

Owner

pbek commented Jul 20, 2016

I will take a look at that.

@pbek

This comment has been minimized.

Owner

pbek commented Jul 21, 2016

16.07.12

  • the expand/collapse state of the items in the note subfolder tree will not
    be stored while searching and restored when the search field is cleared
    • after a subfolder was created by the search field it will be cleared

@pbek pbek added this to the 16.07.12 milestone Jul 21, 2016

@LightTemplar

This comment has been minimized.

LightTemplar commented Jul 22, 2016

Did you push it to repos? I couldn't get the version.

@pbek

This comment has been minimized.

Owner

pbek commented Jul 22, 2016

it's in the develop branch

@LightTemplar

This comment has been minimized.

LightTemplar commented Jul 22, 2016

Ah ok, I'll wait then.

@pbek

This comment has been minimized.

Owner

pbek commented Jul 24, 2016

There now is a new release, could you please test it and report if the new features work for you?

@LightTemplar

This comment has been minimized.

LightTemplar commented Jul 24, 2016

They work :)
though, it takes some time before the stand is restored, but I can deal with it.
It's much better and the subfolder search can now be used! Thank you!

@pbek

This comment has been minimized.

Owner

pbek commented Jul 24, 2016

great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment