New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monochromic icon #306

Closed
Dreadeath opened this Issue Aug 26, 2016 · 14 comments

Comments

Projects
None yet
3 participants
@Dreadeath

Dreadeath commented Aug 26, 2016

Hello.

I think it is a good idea to add possibility to change tray icon, to the white one specifically. In GNOME 3 dark blue icon is barely seen. Also theming thing will be really nice feature

Cheers :)

@pbek pbek added the enhancement label Aug 27, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Aug 27, 2016

Thank you for your suggestion, do you already have a certain icon in mind (or prepared)?
Theming (for the editor and later the preview) is coming in #280.

@pbek

This comment has been minimized.

Owner

pbek commented Aug 29, 2016

16.08.19

  • finally there are configurable editor color schemes
    • there are two default schemes called Default and Dark that
      are mimicking the current default mode and the dark mode colors
    • you can create as many schemes as you like by copying and
      modifying them
    • you can change the foreground color, background color, bold state,
      italic state and underline state
    • you can export schemes to files and import them again from
      these files
      • if you come up with a good and proven color theme, that should
        be included by default, please let me know

There now is a new release, could you please test it and report if the new features work for you?

@pbek

This comment has been minimized.

Owner

pbek commented Aug 30, 2016

@pbek pbek added this to the 16.08.20 milestone Aug 30, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Aug 30, 2016

16.08.20

  • you can now enable a dark mode system tray icon in the interface settings

There now is a new release, could you please test it and report if the new features work for you?

@Dreadeath

This comment has been minimized.

Dreadeath commented Aug 31, 2016

Yes! Great, thanks! :)

@Dreadeath Dreadeath closed this Aug 31, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Aug 31, 2016

Thank you for testing!

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Sep 3, 2016

I've made some monochromic svg icon for dark theme. How do I test it? Which icon the app uses for tray?

@pbek

This comment has been minimized.

Owner

pbek commented Sep 3, 2016

You would have to build QOwnNotes from source and overwrite the PNG.

I've created this SVG: https://github.com/pbek/QOwnNotes/blob/develop/src/images/icon-dark.svg
And then exported this PNG to use as tray icon in dark mode: https://github.com/pbek/QOwnNotes/blob/develop/src/images/icon-dark.png

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Sep 9, 2016

I've added new dark icon as the pull request. It's the first one for me so I could mess something up. Tell me what you think. It was the first icon making experience for me so there's a room for improvement.

Also I haven't understood what the svg dark icon for since the app uses png one for tray.

@pbek

This comment has been minimized.

Owner

pbek commented Sep 9, 2016

It's looking nice, great job! I will have to test it tomorrow. Is there a reason you did the png a little bit smaller than the original?

We need a vector graphic (as svg is) to get it in other resolutions if there is need for them.

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Sep 10, 2016

I've initially tried original size, but it looked little too big in my plasma tray, so I've used the size similar to other small icons of breeze pack.

@pbek

This comment has been minimized.

Owner

pbek commented Sep 10, 2016

16.09.4

  • added a new monochromic tray icon (thanks a lot @Maboroshy)

There now is a new release, could you please test it and report if the new features work for you?

@pbek

This comment has been minimized.

Owner

pbek commented Sep 10, 2016

@Maboroshy, your icon is looking great in 16.09.4. ;) thanks a lot again!

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Sep 10, 2016

All the credit to original icon author I just tweaked his work a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment