New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming a note breaks links #313

Closed
gesellkammer opened this Issue Sep 6, 2016 · 12 comments

Comments

Projects
None yet
3 participants
@gesellkammer

gesellkammer commented Sep 6, 2016

When a note is renamed, links pointing to that note are broken

QOwnNotes - version 16.09.2 - Launchpad PPA - build 230

@pbek

This comment has been minimized.

Owner

pbek commented Sep 6, 2016

Thank you for reporting, that is a well known issue without an solution. I think @Maboroshy tried to fix that with a script already, maybe he can help you.

@pbek

This comment has been minimized.

Owner

pbek commented Sep 6, 2016

I'm currently trying to come up with something. An option to search and replace the note link in all notes (on one's own risk).

@pbek pbek added the enhancement label Sep 6, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Sep 6, 2016

16.09.3

  • when renaming a note in QOwnNotes and a link to that note was found in
    other notes there now a dialog will be opened to ask if you want to
    rename the urls to the note in all found notes
    • this works if the note was renamed by modifying the first line of
      the note or (if you turned that on) by changing the note name in
      the note list
@pbek

This comment has been minimized.

Owner

pbek commented Sep 6, 2016

There now is a new release, could you please test it and report if the new features work for you?

@pbek pbek added this to the 16.09.3 milestone Sep 6, 2016

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Sep 6, 2016

Bash-note of mine doesn't trace note moving/renaming yet so it's good that you've implemented this feature directly.

@pbek

This comment has been minimized.

Owner

pbek commented Sep 6, 2016

Does the feature work for you, @Maboroshy?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Sep 6, 2016

It works but it has some bugs I was expecting having dealt with links replacements.

If you have 2 links: <note://test> and <note://test_123> and rename test note to test1 this new feature will also change <note://test_123> link to <note://test1_123> and break it.

@pbek

This comment has been minimized.

Owner

pbek commented Sep 6, 2016

You are right, it currently does what it says, replacing text. Maybe we should replace an other text, like one with <> and () enclosures?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Sep 6, 2016

Yep, that was the beginning that get me to !\[[^]]*] *([^)]*) for an in-line image link.

@pbek

This comment has been minimized.

Owner

pbek commented Sep 7, 2016

16.09.4

  • the automatic note link url renaming method of v16.09.3 will now not
    just search for the url but trying to detect markdown links
@gesellkammer

This comment has been minimized.

gesellkammer commented Sep 7, 2016

That works fine, thanks!

On Wed, Sep 7, 2016 at 6:39 AM, Patrizio Bekerle notifications@github.com
wrote:

16.09.4

  • the automatic note link url renaming method of v16.09.3 will now not
    just search for the url but trying to detect markdown links


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#313 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAE9tIIfvyXLRE-7lwgrsk3b1eHF4nxFks5qnkAIgaJpZM4J1yEx
.

@pbek

This comment has been minimized.

Owner

pbek commented Sep 10, 2016

There now is a new release, could you please test it and report if the new features work for you?

@pbek pbek closed this Sep 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment