New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons don't display correctly #331

Closed
michael-rowe opened this Issue Sep 19, 2016 · 15 comments

Comments

Projects
None yet
2 participants
@michael-rowe

michael-rowe commented Sep 19, 2016

Hi there

First of all, thanks for a great app. I've been trying to find something to replace Evernote for ages and this seems to tick (almost) all the boxes I need.

Secondly, I've noticed that the icons in the toolbar seem to come from two different icon sets (see attached screenshot). I'm running Ubuntu 16.04 with arc-dark theme and Paper icon set.

Regards,
Michael
selection_001

@pbek pbek added the question label Sep 19, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Sep 19, 2016

Thank you for your kind words! I like to have all notes in folders. ^_^

QOwnNotes uses free desktop theme icons, if your theme has no icon of a certain kind it falls back to the bundled (Breeze) icons.

Does that answer your question?

@michael-rowe

This comment has been minimized.

michael-rowe commented Sep 19, 2016

Thanks for the quick response. I have Breeze installed but only some of the displayed icons are from that set. Is there a way to "force" QownNotes to use Breeze only?

@pbek

This comment has been minimized.

Owner

pbek commented Sep 19, 2016

I'm not aware of a way to do that without removing the theme icon for every icon in QOwnNotes. Every free desktop theme can define a fallback, you could define that in the theme file of your theme, like in https://github.com/pbek/QOwnNotes/blob/develop/src/icons/qownnotes/index.theme. I wonder why they didn't do that if they theme has not all theme icons...

@pbek

This comment has been minimized.

Owner

pbek commented Sep 19, 2016

But I'm not sure to what icon set you should define it. I wonder how other applications handle this...

@pbek

This comment has been minimized.

Owner

pbek commented Sep 19, 2016

What happens to the icons if you enable the dark mode in the interface settings of QOwnNotes?

@michael-rowe

This comment has been minimized.

michael-rowe commented Sep 19, 2016

As far as I can tell, enabling dark mode does nothing to the UI or the icons. Don't stress about this. The icons that display are fine...I can easily see what they do. It's not like they're completely missing.

@pbek

This comment has been minimized.

Owner

pbek commented Sep 19, 2016

So the desktop theme has highest priority. If I find a way to turn theme icons off, I'll let you know.

@pbek pbek closed this Sep 19, 2016

@michael-rowe

This comment has been minimized.

michael-rowe commented Sep 21, 2016

Just to let you know, the icons change to the proper icons when Dark mode is enabled (I didn't know that the app needs to be restarted for this change to happen...maybe you could include some text in the option that alerts the user? I know it appears when you mouse over the option but it's not clear). When I switch back to the Light mode then the icons change back. Again, not serious, just wanted to let you know that Dark mode does change the icons.

@pbek

This comment has been minimized.

Owner

pbek commented Sep 21, 2016

the icons change to the proper icons when Dark mode is enabled

Thank you for letting me know, I will take a look at this.
Just to confirm, in dark mode you see dark mode icons (kind of inverted), right?

maybe you could include some text in the option that alerts the user

There already is a tooltip for that...

@michael-rowe

This comment has been minimized.

michael-rowe commented Sep 21, 2016

Yes, the dark mode icons appear in dark mode, and they're all from the same icon set. When I switch back to Light mode, the icons seem to come from two different sets.

@pbek

This comment has been minimized.

Owner

pbek commented Sep 21, 2016

ok, thank you!

@pbek pbek added this to the 16.10.1 milestone Oct 2, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Oct 2, 2016

16.10.1

  • there now is a new checkbox Use internal icon theme instead of system icon theme in the interface settings
@pbek

This comment has been minimized.

Owner

pbek commented Oct 4, 2016

There now is a new release, could you please test it and report if the new features work for you?

@michael-rowe

This comment has been minimized.

michael-rowe commented Oct 4, 2016

Thanks, the icons show up perfectly with the new setting enabled.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 4, 2016

Great, thank you for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment