New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling tag / subfolder pane turns off tag visibility in the note #343

Closed
michael-rowe opened this Issue Sep 29, 2016 · 73 comments

Comments

Projects
None yet
4 participants
@michael-rowe

michael-rowe commented Sep 29, 2016

When I turn off the tag / subfolder pane in the Window setting it also turns off the tag visibility in the actual note. Is this by design? I'd like to turn off the tag panel but want to still see the tags in the notes I'm working on. Is this possible?

@pbek

This comment has been minimized.

Owner

pbek commented Sep 30, 2016

Currently there is no other way to turn off tagging altogether than to turn off the tagging pane for those who doesn't want to use it. Any suggestions?

@pbek pbek added the enhancement label Sep 30, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Sep 30, 2016

maybe @Maboroshy?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Sep 30, 2016

I'm started to write some big post about evolution and redefining of the app UI as usual, but there can be short solution...

Merge tag panel with status bar.

Status bar is a huge screen wide panel mostly unused be the app, and as I've understood from the Qt docs any widget can be placed there. There can be buttons of current tag panel, text form for quick tagging and some extra info on the current note. And it can be toggled on/off by user.

Most other advanced note apps tend having that kind of status bar above note editor though.

@pbek

This comment has been minimized.

Owner

pbek commented Sep 30, 2016

@Maboroshy, you are the grand master of big posts! :) But not today, so it seems. ;)

Hm, don't you think having tags in the status bar would be very confusing? And I wouldn't be able to create those scrollbars if there are too many tags if they are in the status bar. Beside that what's the point of having it at all then if it can't show status messages any more? :) Maybe we just settle for an other checkbox in the window menu...

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Sep 30, 2016

This week has wear me off a bit.

Your point seems true. There should be some other solution.

But there was a rant in my unwritten post that putting yet another toggle for tag panel will break "no pane - no tags" principle of the app UI and will be a beginning of having toggles for every UI element... Which is not bad by itself if that's the direction you want to take.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 1, 2016

Oh, this week is also for me a very demanding one...

Which is not bad by itself if that's the direction you want to take.

The "problem" with us humans is, that everyone wants something different...

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 1, 2016

"Be careful what you wish for..."

Personally I'm all for maximum customization. But we have already seen the issues of the users overwhelmed by to many options.

Currently we control UI by panes and by view modes. Pane is the "unit" of UI. Tag panel is linked to this kind of unit.

Now we make panel a controllable element. It's like you have the list of options like 1, 2, 3, 3.2, 4...
What does 3.2 doing here, it's not in row. Well, it was a special case... But is it really special? If we go to 0.1 level logically next stop is having toggles for tag and sub-folders parts of tag pane, navigation panel, and that's for every view mode.

I'm all for that, because I don't use half of it and will gladly turn it off. But it will take a lot effort to make it look neat without making UI frustratingly complex.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 1, 2016

Letting the user control everything (the opposite of the Apple way) always adds complexity... So what would be the best course now? :)

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 3, 2016

More user control without complexity? That's hard to get with current UI. Current UI works like more control = more menu items = more complexity. To get beyond that some UI principles need to be changed to be more like "big" apps.

What "big" apps do? They getting their vast tool set from "stacks" for user to place each where and how he sees fit. To go that way the app needs it panes atomized to panels with ability to move each panel and dock it where the user wants.

And Qt has a platform for that - QDockWidget.

Current view modes will transform to "workspaces" - user-defined sets of panels with adjustable names.

Window menu will become two short uniformed menus - one with the panel list to toggle each and another to choose, save and delete "workspaces".

This way they will be two real panes left - editor and render.

Of course sane default "workspaces" close to what app has now is a must. So that newbie users wouldn't need to change anything.

If you wanted best course that is the one. 😉

@pbek

This comment has been minimized.

Owner

pbek commented Oct 3, 2016

That sounds like a great idea. It leaves me to find out how to use QDockWidgets and if they can be used in the current project without starting from scratch...

But the problem that people will expect to be able to turn on and off elements on the fly with shortcuts still remains...

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 4, 2016

You have already solved that for hiding menu bar.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 4, 2016

You mean by a lot of checkboxes? :)

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 4, 2016

Maybe I've misunderstood. What did you mean by shortcuts?

@pbek

This comment has been minimized.

Owner

pbek commented Oct 4, 2016

Keyboard shortcuts. We need menu actions for those (e.g. checkboxes). And so we again have a multitude of menu entries... ;)

@pbek

This comment has been minimized.

Owner

pbek commented Oct 4, 2016

QDockWidget seems great and no to hard to integrate. But we are pretty restricted where the widgets can be placed: http://doc.qt.io/qt-5/qdockwidget.html#details
If we want everything floating there only can be placed in either Qt::LeftDockWidgetArea or Qt::RightDockWidgetArea. Currently we have up to four columns...

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 4, 2016

This article made me think there is some more functionality.
Also why do you exclude bottom and top areas? The good place for the tag panel which is the subject of the issue may be below editor. These areas are the key to having vertical layouts the app has now.

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 4, 2016

Maybe there's a need to investigate if render pane can be a QDockWidget too instead of being part of central widget, so having vertical editor-render layout would be part of new conception instead of being leftover of the old one.

But I haven't yet used the Qt app with a moveable widget of this size.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 4, 2016

Top and bottom are not excluded, but they don't give me an other column. Qt 5.6 features will not let us get around that (beside it has to work down to Qt 5.3).
So far I only know of the QMainWindow that can have QDockWidgets...

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 4, 2016

The video shows that it's possible to but two widgets to the same area as "columns". This feature is not new. If I understand correctly it was there at least from Qt 4.3.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 4, 2016

You are right, it really shows two columns. I have to investigate that more!

@pbek

This comment has been minimized.

Owner

pbek commented Oct 5, 2016

I found workarounds for most of the bugging things. I even found a way to remove the title bar of an dock element to save space (that might be a new checkbox "lock down dock elements").
I'm thinking of introducing dynamic modes where the user can move (or remove) docks as they like and the states of the docks will be stored. Those states can then later be restored for example to turn on and off the preview. The user might define "mode 1" with preview and "mode 2" without preview. There could be shortcuts for those modes... What do you think, @Maboroshy?

@pbek

This comment has been minimized.

Owner

pbek commented Oct 5, 2016

That would eliminate the need for a lot of checkboxes.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 5, 2016

@Maboroshy there is a new branch feature/dockwidgets in case you want to peek at the progress by building QOwnNotes yourself.
https://github.com/pbek/QOwnNotes/tree/feature/dockwidgets

All the panes (even note folders and navigation) are dockable and there is a "lock panels" button to disable the title bars. The placement (even if floating) is already remembered. Of course a lot of work still have to be done, especially integrating with the old behaviors and removing of a lot of old styling and moving around code.

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 5, 2016

I'm thinking of introducing dynamic modes where the user can move (or remove) docks as they like and the states of the docks will be stored. Those states can then later be restored for example to turn on and off the preview. The user might define "mode 1" with preview and "mode 2" without preview. There could be shortcuts for those modes... What do you think, @Maboroshy?

Sound like the "workspaces" idea I posted. I think there should be some basic management for saving with user-defined name and deleting saved "workspaces"/states. Shortcuts can follow their order like F1 - F10 with an ability to rebind.

Some checkboxes have stay to activate closed panels. But it will be quite short neat list instead of mix of panes and modes like it is now.

So list of panels and list of saved states will cover any combination. And making new features will be adding panels without the need to arrange hard-coded layouts every time.

I'll try building this new branch.

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 5, 2016

I've tried it and it's very cool! Very simple and powerful.

If I understand correctly the layout of this version has no central widget. That creates an empty space between dock areas you have to cover by getting panels together. Without that central widget it also hard to understand where the panels docked, what is the reference point. I do understand that it was made to make editor and render both toggle-able. Maybe you could try putting a version where render and editor are old school panes acting as a central widget. That may be more intuitive.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 5, 2016

Thank you for your feedback!

That's right, no central widget because that would not have been movable. All dock widgets start in the left area, so the gap is on the right. What reference point do we need in your opinion? Currently preview and editor can be placed vertically and they can even be tab-able. Both wouldn't be able in the same way if one of them or both are a center widget.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 6, 2016

Later I found out that the current "layout" looks hideous in fullscreen / maximized mode. If I can't find a solution to that I really will have to leave the edit (and maybe also the preview) in the content area. Too bad, because I wanted to make the note tag pane also dockable...

@pbek

This comment has been minimized.

Owner

pbek commented Oct 6, 2016

I finally got around the troubles, the docks are now places where they should and there is no gap at the right any more! Everything (plus the note tags) are still dockable! What do you think, @Maboroshy, my trusted product manager?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 6, 2016

It works quite good.

Can't check .ui file in designer, for some reason it shows the old layout. You've made the single docking area to work it out, didn't you? That way there's also no way to dock anything screen-wide above or below. But the app currently doesn't have anything suited for that so not a big deal.

For some reason the note editor doesn't show up, but that maybe due to I'm lame at building the app.

Toolbar with panel drop down selector is ugly when vertical, but it's doubled in menu and bindable.

The lock button could lock the toolbars too. Don't know if it should also lock panel sizes.

I'm not sure that context menu for activating panels is intuitive. It takes little but still some skill to get it with screen full of widgets. Maybe it's worth own place in main menu.

Looks like storing layouts doesn't work yet. Clicking layouts in menu also doesn't affect drop-down selector.

Is menu, status and tool bars are part of saved layout? That way distraction free mode can be just another layout.

Note root selector should be a separate panel instead of embedded into note list.

Sub-folders panel sometimes goes fixed zero size. Need to investigate more what causes it. Maybe that also the building issue of mine.

Preview got some big empty horizontal scroll I don't remember it had.

Overall it's very cool, UI feels like "photoshop" for notes.

@michael-rowe

This comment has been minimized.

michael-rowe commented Oct 11, 2016

Just wanted to say that I love the new dockable panels. I haven't come across any problems so far. Thanks for this update.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 11, 2016

Thank you for your feedback @michael-rowe, I've already found and fixed some issues I found for the next releases... But there are still some more. ;)

@pbek

This comment has been minimized.

Owner

pbek commented Oct 11, 2016

16.10.3

  • fixed a problem when the note edit panel was hidden before entering
    the distraction free mode
  • fixed a problem with the restoring of the last workspace correctly
    when starting the app maximized
  • the note folder combobox and the note search line edit now have their
    own movable panels
    • as a consequence the Show note folders in main area checkbox in
      the interface settings was removed
    • if the note folder combobox was hidden while the Select note folder
      shortcut in the main menu was pressed the panel will be hidden
      again after the combobox was closed
    • you have to move the two new panels to their proper places if you
      have already used version 16.10.2
  • decreased the possible minimal height of the note tag panel

There now is a new release, could you please test it and report if the new features work for you?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 11, 2016

There are some minor issues.

I have two workspaces: one with note folder combox, note list panel, note sub-folder panel and note editor and the other with same but render instead of editor. All at the same places.

When I switch between them, no mater which way, combox gets focus (becomes blue) on the render workspace. It works as usual for editor workspace (no focus on switch) though.

When I switched to the folder that has sub-folders disabled in options editor workspace had sub-folder panel gone with empty space on it's place. But when I switched to render workspace there were sub-folders of a previous folder.

The app saves sub-folder panel to workspace and disables it only on folder change event in that workspace. Using refresh key solves the issue so maybe you could make hook for a force refresh somewhere where it'd cause less pain.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 11, 2016

I'm not sure what you are talking about and if you are talking about one thing or multiple. :) The subfolder panel will be hidden if subfolders are turned off for the current note folder.

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 11, 2016

I'm talking about two issues: with focus and with sub-folder panel.

The subfolder panel will be hidden if subfolders are turned off for the current note folder.

For current folder and for the current workspace only. Try it.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 11, 2016

I think I still fail to make sense of your words... So what is the focus issue? You are loosing focus of the current widget that has focus when you are switching to an other workspace?

And what is the issue with the subfolder panel?

@pbek

This comment has been minimized.

Owner

pbek commented Oct 11, 2016

I now already fixed the restoring of the focus after switching workspaces.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 12, 2016

@Maboroshy but I still don't know what issue you had with the subfolder panel. ;)

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 12, 2016

  1. Add two folders, turn sub-folders mode on for the first one.
  2. Make two workspaces with sub-folder panel.
  3. You have two workspaces with the same first folder active. Sub-folder panel is on on both.
  4. Choose second folder at one workspace, the panel will be gone.
  5. Go to second workspace. The second folder is active but the panel will be there with sub-folders of the first folder.
  6. Press refresh and the panel will be gone as it should.
@pbek

This comment has been minimized.

Owner

pbek commented Oct 12, 2016

So in one sentence: The subfolder panel is not hidden when switching workspaces if subfolders are turned off for the note folder. Is that correct?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 13, 2016

Mostly. It will be and stay hidden if you refresh the workspace.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 13, 2016

from the change log

16.10.4

  • fixed the restoring of the focus after switching workspaces
  • the log dialog is now a dockable panel that can be placed everywhere
  • fixed a problem with showing the title bar of floating panels after
    application start
  • fixed a problem where the note folder select box was hidden
  • the subfolder dock widget is now turned on or off according to whether
    the subfolders are enabled or not when the workspaces are switched

There now is a new release, could you please test it and report if the new features work for you?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 13, 2016

All good for me. I'm impressed how fast and smooth transition to new UI went.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 13, 2016

Thank you for testing and reporting! I can assure you it was a lot of work. :) But you were my top-most driving factor to get me going doing it. 😸

@pbek pbek closed this Oct 13, 2016

@danielsanfr

This comment has been minimized.

danielsanfr commented Oct 15, 2016

I just upgraded and noticed it was removed the option to switch between edit mode and preview mode. For me this was a major downgrade 👎... I do not like having to keep both views ever!

I would suggest doing something like this: Typora. I am willing to help the development, if necessary.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 15, 2016

@danielsanfr, you can simulate that behavior.
From the changelog for 16.10.2:

  • there is a button to switch between the last two workspaces for example to toggle between edit and preview if you don't want to show both panels

It even has the same default shortcut.

@danielsanfr

This comment has been minimized.

danielsanfr commented Oct 19, 2016

You're right. The problem was that was not explicit how to do this for me.

But now I got it, thank you very much for your help and for developing this application!

I think to do something like Typora the editor would be amazing!

@pbek

This comment has been minimized.

Owner

pbek commented Oct 20, 2016

I'm glad it worked out for you.

I think to do something like Typora the editor would be amazing!

Can you please describe what "do something like" is for you? :)

@pbek

This comment has been minimized.

Owner

pbek commented Oct 20, 2016

@Maboroshy, as usual your wish was my command:

16.10.6

  • the buttons in the toolbars can now be customized
    (for Issue #343)
    • there is a new Toolbars pane in the settings to add buttons from
      the main menu to toolbars, move buttons around or remove buttons
    • you can as well add custom toolbars
    • if you have messed the toolbars up you can also reset the toolbars
      to the default

It was quite some work. ;)

@pbek

This comment has been minimized.

Owner

pbek commented Oct 20, 2016

there are still some issues, like that the window toolbar can't be modified because of the magic that is happening there

@pbek

This comment has been minimized.

Owner

pbek commented Oct 20, 2016

@Maboroshy there now is a new release, could you please test it and report if the new features work for you?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 20, 2016

Very cool! Looks very close to what KDE guys have. There's even a custom actions buttons there! And I was just thinking about separators for bash-note toolbar I've made. I'll give it a try and post what I find.

By the way, you only take thoughtful and proved "wishes" as commands, I've tried some stupid ones and that didn't work. 😄

@pbek

This comment has been minimized.

Owner

pbek commented Oct 20, 2016

I took extra time to make the custom actions in custom toolbars work... ;)

By the way, you only take thoughtful and proved "wishes" as commands, I've tried some stupid ones and that didn't work.

lol, I'm glad that the vast majority of your thoughts are thoughtful :)

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 20, 2016

And my first try was to extend custom actions toolbar with some buttons. Reloaded the script and it got reset. 😧

@pbek

This comment has been minimized.

Owner

pbek commented Oct 20, 2016

That toolbar gets reloaded along with the script engine (naturally). Better use a custom toolbar and add your custom actions.

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Oct 20, 2016

Ok, here's what I've found after first pass. Since that's the first time I paid that much attention to toolbars which I have mostly off, I may have added some things beyond the feature scope.

Settings UI:

  • Buttons in the middle are very wide and far form each other. That means big distances for eyes and mouse without any gain.
  • Available and toolbar action columns are not labelled which makes new user confused for a few moments. Same with insert/remove buttons, maybe left/right would be better.
  • All the above = take a look at KDE UI for that, like the one in Dolphin.
  • The folder names from note folder section can be added but they won't appear on toolbar. Similar workspaces name work.
  • Folder names in the section tend to multiply. Looks a change of workspace causes it.
  • You can't assign icon to a "name". I do understand that change icon UI is a hell for cross-platform app though. Good thing I know of endless Unicode tables. But please add icon to "Select note folder" item! It's the only "normal" item which has none.
  • Separator icon is little weird. Maybe it'd be better same as on the list - "--- Separator ---".

Appearance:

  • Some buttons, specifically the ones with drop-down like folders and workspaces are removed when app language (localization) is changed.
  • Lock panels button is "pressed" when panels are locked. Pretty logical. But while the panels are mostly locked seeing "pressed" button all the time is distracting. Maybe it'd better be "Unlock panels" button.
  • Reload folder and reload scripting engine have the same icon. I propose change the scripting one to `step_object_LinearMotor.svg' from the Breeze set.
  • Maybe it's time to ditch quite toolbar since it was there for a rare special purpose and you now have that covered.

Custom actions:

  • Reloading scripts don't reload toolbars, so dead custom action buttons will still be on toolbar.
  • When you've thought that that's how it should be, app restart will remove all custom action buttons from toolbar. And they won't come back when you'll add the script back.
  • When tinkering with custom actions their toolbar like to pop-up on active workspace even when it was disabled before. Maybe it should always be but be empty when there's no actions.

But overall very good and very useful. Going to start using toolbar at last! And less "I want new button" issues for you! Complete user control.

@pbek

This comment has been minimized.

Owner

pbek commented Oct 21, 2016

Thank you for your elaborative feedback, I hope anyone else beside you spots one or two of these things. :) Could you please open a new issue with all this...

@pbek

This comment has been minimized.

Owner

pbek commented Oct 21, 2016

@Maboroshy thank you (topic moved to #368)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment