New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt UI does not follow KDE's icon set on Fedora 23 #39

Closed
xenithorb opened this Issue Jan 31, 2016 · 9 comments

Comments

Projects
None yet
2 participants
@xenithorb

xenithorb commented Jan 31, 2016

snapshot2

I have breeze-dark set as my icon theme for obvious reasons, and you can see that the icon set being use is the default breeze theme.

@pbek pbek added the enhancement label Jan 31, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Jan 31, 2016

Hi @xenithorb, thank you for your report!
So far QOwnNotes doesn't follow any icon set, it has it's own icons. I just borrowed various Breeze SVG icons from KDE as icons for QOwnNotes.
A full set of dark themed icons would be great...

@pbek pbek added the help wanted label Jan 31, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Feb 11, 2016

It was quite some work, but I did it.

In v0.97 QOwnNote now uses default freedesktop theme icons

  • for Windows and OS X there is a bundled fallback theme with Breeze icons
    that will be used when the operating system hasn't a theme set
  • this allows the usage of QOwnNotes with dark system themes

Could you be so kind and test v0.97 when it is out.

@pbek

This comment has been minimized.

Owner

pbek commented Feb 11, 2016

v0.97 is out now. 😁

@xenithorb

This comment has been minimized.

xenithorb commented Feb 11, 2016

qownnotes_icons_fixed

Works great, Thanks for your hard work!

@xenithorb xenithorb closed this Feb 11, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Feb 11, 2016

Perfect, thank you!
Although I have to do a workaround for OS X... No icons at all at the moment even tho it worked on my Macbook while developing...

@pbek pbek reopened this Feb 12, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Feb 12, 2016

Can you please verify that it still works in v0.98 and that the search bar in the note text edit (Ctrl + F) also uses theme icons?

@xenithorb

This comment has been minimized.

xenithorb commented Feb 12, 2016

qownnotes_icons_fixed3

The icons are of the correct type, but the "search backward" placement is right-aligned and z-indexed below the scrollbar

@pbek

This comment has been minimized.

Owner

pbek commented Feb 12, 2016

Thank you for reporting back. Oh, what would I give if I could fix that issue with a CSS z-index, but that problem lies much deeper...

@pbek pbek closed this Feb 12, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Feb 14, 2016

I finally found a fix for that, it will be in the next version. Thank you for pushing me. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment