New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image files are invisible on file browser window using insert image function #391

Closed
Manu-sh opened this Issue Nov 17, 2016 · 28 comments

Comments

Projects
None yet
2 participants
@Manu-sh

Manu-sh commented Nov 17, 2016

Image files are invisible on file browser window using insert image function https://anonm.gr?14a5.png

@pbek

This comment has been minimized.

Owner

pbek commented Nov 17, 2016

Thank you for reporting.
I just tested on Windows 8.1 and they were visible for me in the file-open dialog.
Can you please post the output from the debug settings.

@Manu-sh

This comment has been minimized.

Manu-sh commented Nov 17, 2016

md: https://arin.ga/UR3KJo
strace (splitted): https://arin.ga/UQyL3u

the path is /home/user/Immagini/vaporwawe_wall
i suggest to start from line 1126
the information provided by log doesn't report any error, only line like this:
[nov 17 13:23:25] [warning]: libpng warning: iCCP: known incorrect sRGB profile

@pbek

This comment has been minimized.

Owner

pbek commented Nov 17, 2016

Oh, I thought you were using Windows...
It also works for me in KDE Neon.

@pbek

This comment has been minimized.

Owner

pbek commented Nov 17, 2016

What Desktop Environment are you using?

@Manu-sh

This comment has been minimized.

Manu-sh commented Nov 17, 2016

I use xfce on my notebook, but after i can test on another pc with gnome

@pbek

This comment has been minimized.

Owner

pbek commented Nov 17, 2016

QOwnNotes tries to use the native file open dialog (via Qt). I'm not sure which dialog you are using under xfce. You can also drag and drop images to QOwnNotes.

@Manu-sh

This comment has been minimized.

Manu-sh commented Nov 17, 2016

I don't think that this is the problem because qtcreator show those file, however maybe after i can try to make more test

@Manu-sh

This comment has been minimized.

Manu-sh commented Nov 17, 2016

@pbek i have also try on another pc with gnome and same issue, i use arch linux on both my pc, the current version of Qt is 5.7.0

@pbek

This comment has been minimized.

Owner

pbek commented Nov 17, 2016

Strange, I can see them under Manjaro (Arch with KDE) under Qt 5.7. Can you please post a screenshot of the dialog under Gnome.

@Manu-sh

This comment has been minimized.

Manu-sh commented Nov 17, 2016

Ok, i have make following test:
On gnome and kde with version 16.11.11:

then i have also clone and build from branch master, previously i have used develop branch:
but same issue, then i have try to build without using parallel jobs but doesn't solve anything
for build i have used following commands:

git clone https://github.com/pbek/QOwnNotes -b master
cd QOwnNotes
git submodule update --init
cd src
qmake
make
sudo make install

edit: i have also reinstall those library: sudo pacman -S qt5-base qt5-svg qt5-declarative
and rebuild, but nothing to do
re-edit: and also with yaourt package

@pbek

This comment has been minimized.

Owner

pbek commented Nov 17, 2016

Can you please create a .enex file and try if you see it in the Evernote importer?
Do you have similar problems with other KDE Applications if file extensions are filtered?

@Manu-sh

This comment has been minimized.

Manu-sh commented Nov 17, 2016

.enex files are correctly shown

@pbek

This comment has been minimized.

Owner

pbek commented Nov 17, 2016

interesting, and you you have any Qt application that opens files with multiple formats in one filter (like the QOwnNotes image open dialog)?

@Manu-sh

This comment has been minimized.

Manu-sh commented Nov 17, 2016

No multiple formats no, Qtcreator show JPEG or PNG etc.. but no multiple formats

@pbek

This comment has been minimized.

Owner

pbek commented Nov 18, 2016

I hope I can reproduce that somewhere.

@pbek

This comment has been minimized.

Owner

pbek commented Nov 18, 2016

It also worked under Unity in a Ubuntu 14.04 and in openSUSE Leap.
I used the syntax from the documentation for setting up the filter.

I'm not sure what I can do. Since you seem to build QOwnNotes yourself you could try to modify the filter string.

@pbek

This comment has been minimized.

Owner

pbek commented Nov 18, 2016

I also tried to use dialog.setOption(QFileDialog::DontUseNativeDialog, true); to get the non-native dialog. It worked there too...

@Manu-sh

This comment has been minimized.

Manu-sh commented Nov 18, 2016

@pbek i don't have experience with C++ or Qt framework but i have try to replace this line:
dialog.setNameFilter(tr("Image files (*.jpg *.png *.gif)"));

with this (just for test):
dialog.setNameFilter(tr("Images (*.jpg *.png *.gif)"));

copied from http://doc.qt.io/qt-5/qfiledialog.html, and now work properly
(i have also insert an image without any problem)

https://anonm.gr?8b9c.png

then i suspect that you have install more Qt version on your pc and for this reason work, but i don't know...

@pbek

This comment has been minimized.

Owner

pbek commented Nov 18, 2016

Oh, I now think I saw spaces in the *.jpg *.png *.gif expressions in your first screenshot. You are using the Italian translation. So that's the problem. Can you please test to use the original code and switch the language to any other language than Italian.

@pbek

This comment has been minimized.

Owner

pbek commented Nov 18, 2016

I tried it myself too. The Italian translation for that string is "broken". I think I will exclude the file extensions.

@Manu-sh

This comment has been minimized.

Manu-sh commented Nov 18, 2016

Yes @pbek i have change language from it to en and now work properly

@pbek

This comment has been minimized.

Owner

pbek commented Nov 18, 2016

Thank you for testing.

@Manu-sh

This comment has been minimized.

Manu-sh commented Nov 18, 2016

Thank you for this program is really useful for me

@pbek

This comment has been minimized.

Owner

pbek commented Nov 18, 2016

Thank you for your kind words and your effort on the Italian translation!

@pbek

This comment has been minimized.

Owner

pbek commented Nov 19, 2016

16.11.13

  • Fixed a problem with inserting images when application language is Italian
    • potential file open dialog filter problems in other languages were
      also fixed in the process

@pbek pbek added this to the 16.11.13 milestone Nov 19, 2016

@pbek

This comment has been minimized.

Owner

pbek commented Nov 19, 2016

There now is a new release, could you please test it and report if the dialog works for you?

@Manu-sh

This comment has been minimized.

Manu-sh commented Nov 19, 2016

Yes i can confirm, now image files are correctly shown

@pbek

This comment has been minimized.

Owner

pbek commented Nov 19, 2016

Great, thank you!

@pbek pbek closed this Nov 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment