Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Dark Colour Scheme does not update foreground/background colours #429
You would need to turn off the dark mode then and manually set the background color of the note edit the way you like with stylesheets in a script.
See http://docs.qownnotes.org/en/develop/scripting/README.html#add-a-custom-stylesheet for documentation about the command you need.
The style you want to modify in a script like https://github.com/pbek/QOwnNotes/blob/develop/doc/scripting/custom-stylesheet.qml is
Does that help?
referenced this issue
Dec 22, 2016
@pbek I can give that a go but would have thought the point of the colour scheme having background/foreground colour options would be enforced instead of overwritten by the system theme?
Would it not make sense to run that logic when applying the colour scheme regardless? Is there a use case where that is bad/undesirable for a user to use the colourschemes background/foreground? I'd think that would be more niche as the colour schemes don't look right with the different(at least opposite) bg/fg than the scheme intended.
See my settings page, I use the dark colour scheme. My KDE theme is Breeze Light, standard/default with KDE install. I wanted to have dark colour scheme apply properly withouot force dark mode or change to Breeze Dark. It should work with Breeze Light for the toolbar like shown, only editor pane shouold be affected by colour scheme like settings suggest. Notice that it says background is black and foreground is white? See the preview in settings? Then on editor pane after apply, colour scheme work except background is white and foreground(text) is black, wrong way and now editor pane look wrong, not like preview in settings.
You suggest a fix with a script, but I think this is expected functionality. If you can force background/foreground to use colour from colour scheme so it looks like preview, I believe everyone want this, why would they want it to look like my screenshot? The screenshot from Haroopad shows what I expect, dark editor pane, light preview pane, Breeze Light theme(it does not have nice toolbar and other panes like QOwnNotes unfortunately, however you can see from menu bar that it is still light theme which is good).
@pbek Maybe most people use dark mode with a dark theme?
For example, if I select the beautiful AnalyticalYellow scheme:
This is how it looks in light mode:
And this in dark mode:
For contrast, this is Light color scheme with dark mode on (which also looks odd):
So I guess @polarathene has a point in that the background of the text editor should follow the color scheme and not the program's theme.
That said, I don't know how hard it is to make the text editor to follow the color scheme's background so I leave that decision to you @pbek :)
@richarson, thank you for letting me know in a simple sentence what @polarathene was talking about. :) It was actually a great idea!