New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Image as link" markdown syntax highlighting #463

Closed
Maboroshy opened this Issue Jan 7, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@Maboroshy
Contributor

Maboroshy commented Jan 7, 2017

Pandoc converts "images as link" to a [![name](image)](link) constructs.

At first I thought that it's a misbehaviour. But looks like it's a valid markdown, and the app renders it correctly.

Maybe it's worth to add support for such syntax to the highlighting engine.

@pbek pbek added the enhancement label Jan 7, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Jan 7, 2017

I haven't seen such a link before. :) Should we highlight it as a link?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jan 7, 2017

For me it's an image first, link second. I'd go for an image.
But logically it's a link that has an image as a name.

@pbek

This comment has been minimized.

Owner

pbek commented Jan 8, 2017

17.01.3

  • image links like [![name](image)](link) and [![](image)](link) will now
    also be highlighted

@pbek pbek added this to the 17.01.3 milestone Jan 8, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Jan 8, 2017

There now is a new release, could you please test it and report if the new features work for you?

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Jan 8, 2017

Everything works. Thanks.

@Maboroshy Maboroshy closed this Jan 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment