New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abnormal cpu/memory usage when searching for text using Note search panel #469

Closed
onelittlehope opened this Issue Jan 7, 2017 · 9 comments

Comments

Projects
None yet
2 participants
@onelittlehope

onelittlehope commented Jan 7, 2017

To reproduce:

  • Replicate a clean start by ensuring no previous configs exist: rm -rf ~/ownCloud/ .config/PBE/ .local/share/PBE/
  • Start: QOwnNotes
  • Enter the following text in the "Note search" panel: I will search for the string it also happens with: ^_ (where _ = space character)

issue

@pbek

This comment has been minimized.

Owner

pbek commented Jan 8, 2017

Thank you for reporting, I will try to reproduce your issue under Linux. I couldn't under macOS...

@pbek

This comment has been minimized.

Owner

pbek commented Jan 8, 2017

I neither can reproduce this on KDE Neon.

@onelittlehope

This comment has been minimized.

onelittlehope commented Jan 8, 2017

Is there a debug build I can use to help narrow down the issue? I looked at the source code and I wasn't sure whether a search is carried out against a SQLite DB (which is hanging) or whether its a regex search which is hanging. If you could confirm what components are involved in doing a Note search (source file + function), I can then check whether the versions of libraries involved are sufficiently different to cause the behaviour.

I can reproduce this consistently in Windows 10 + Linux if I type in ^_ (where _ = space character) in to the "Note search" panel.

I just updated to QOwnNotes 17.01.3 on both Linux and Windows 10 and the issue was reproducible by:

  • Switching to the "full" workspace
  • Entering ^_ (where _ = space character) into the "Note search" panel.

Ps. Thank you for implementing the Ctrl+F (Find in note) functionality in the "Note preview" panel and for putting the two default workspaces as "full" / "minimal".

@pbek

This comment has been minimized.

Owner

pbek commented Jan 9, 2017

I guess it will search for "everything not a space", that could take a while... :)

@pbek

This comment has been minimized.

Owner

pbek commented Jan 9, 2017

Ps. Thank you for implementing the Ctrl+F (Find in note) functionality in the "Note preview" panel

there is no Ctrl+F for it, but the search panel also shows results in the preview

@pbek

This comment has been minimized.

Owner

pbek commented Jan 10, 2017

17.01.4

  • fixed an issue with the note search getting stuck when searching for ^ or (just spaces)

@pbek pbek added this to the 17.01.4 milestone Jan 10, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Jan 10, 2017

There now is a new release, could you please test it now works for you?

@onelittlehope

This comment has been minimized.

onelittlehope commented Jan 10, 2017

I confirm that entering ^ no longer hangs QOwnNotes and causes it to use 100% cpu and lots of memory. The issue is fixed. Thanks.

@pbek

This comment has been minimized.

Owner

pbek commented Jan 10, 2017

Great, thank you for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment