New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to note in subfolder #478

Closed
gesellkammer opened this Issue Jan 13, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@gesellkammer

gesellkammer commented Jan 13, 2017

The title says it: it seems to not be possible to link to a note in a subfolder.

Using version 17.01.5

Thanks!

@pbek pbek added the enhancement label Jan 14, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Jan 14, 2017

Yes, that's right. The links themselves can only link to a note that is visible in the note list and the link dialog only shows notes from the current note sub-folder. Changing that would be a tremendous amount of work and then the next issue would be that users would move notes or rename note sub-folders and the links would break again... So currently I keep my fingers of it.

@pbek pbek added the wontfix label Jan 14, 2017

@pbek pbek closed this Jan 14, 2017

pbek added a commit that referenced this issue Sep 9, 2018

pbek added a commit that referenced this issue Sep 9, 2018

#478, implemented note sub-folders switching and possibly duplicate e…
…ntries in the script list of the script repository

pbek added a commit that referenced this issue Sep 9, 2018

pbek added a commit that referenced this issue Sep 9, 2018

@pbek pbek added this to the 18.09.1 milestone Sep 9, 2018

@pbek pbek removed the wontfix label Sep 9, 2018

@pbek

This comment has been minimized.

Owner

pbek commented Sep 9, 2018

@Snousmoumryk, @gesellkammer, @Maboroshy I rewrote a lot of parts of the note linking to make that possible now

18.09.1

  • note links will now also jump to notes in other note sub-folders
    • first only the current note sub-folder will be searched, if the note wasn't
      found there all note sub-folders will be searched
    • if the linked note was in another note sub-folder the current note
      sub-folder will be changed to that note sub-folder
    • the note link dialog now shows notes of all note sub-folders
    • highlighting of note links if they are broken also works over all note sub-folders
    • automatically updating links when notes are renamed should now also work
      across note-subfolders

There now is a new release, could you please test it and report if it works for you?

@pbek pbek reopened this Sep 9, 2018

@Snousmoumryk

This comment has been minimized.

Snousmoumryk commented Sep 9, 2018

18.09.1
please test it and report if it works for you

It works just fine, that it's exactly what I had in mind.
Thank you, @pbek

@pbek

This comment has been minimized.

Owner

pbek commented Sep 9, 2018

Great, thank you for testing!

@pbek pbek closed this Sep 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment