New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom colours not saving on macOS #503

Closed
dtougas opened this Issue Jan 31, 2017 · 9 comments

Comments

Projects
None yet
2 participants
@dtougas

dtougas commented Jan 31, 2017

I am using QOwnNotes version 17.01.13 (build 2759) on Mac OS X 10.12.2 and am unable to save colours in my custom font themes. If I copy an existing font theme, everything is black and any colour changes I make are not saved and revert back to black. Font size changes work properly.

@pbek

This comment has been minimized.

Owner

pbek commented Jan 31, 2017

Thank you for reporting, it's very strange. It works on Linux, but doesn't on macOS.

@pbek

This comment has been minimized.

Owner

pbek commented Jan 31, 2017

Unfortunately it's a QColor serialization bug in Qt.
https://bugreports.qt.io/browse/QTBUG-56565
I can reproduce the same issue...

under macOS:

Debug: set value:  QVariant(QColor, QColor(ARGB 1, 0.639216, 0, 0.482353))
Debug: get value:  QVariant(QString, "@Variant(")

under Linux:

Debug: set value:  QVariant(QColor, QColor(ARGB 1, 0.858824, 0.976471, 0.898039))
Debug: get value:  QVariant(QColor, QColor(ARGB 1, 0.858824, 0.976471, 0.898039))

We are currently stuck with Qt 5.5.1 on macOS because I didn't manage to get later versions to work on TravisCI (the build system) so far...

@pbek pbek changed the title from Custom colours not saving to Custom colours not saving on macOS Jan 31, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Jan 31, 2017

The only thing you can currently try is creating a color schema on an other operating system and import it on macOS.

@pbek

This comment has been minimized.

Owner

pbek commented Jan 31, 2017

I will close this issue until there is more information.

@pbek pbek closed this Jan 31, 2017

@pbek pbek added bug wontfix labels Jan 31, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Feb 1, 2017

17.02.0

  • disabled the Copy button in the Note editor font schema settings under macOS because of a Qt bug for Qt versions lower than 5.8
@pbek

This comment has been minimized.

Owner

pbek commented Feb 2, 2017

I finally did it today! Copying works now!

17.02.1

  • QOwnNotes for macOS is finally deployed with Qt 5.8, solving some pesky Qt bugs

@pbek pbek removed bug wontfix labels Feb 2, 2017

@pbek pbek added this to the 17.02.1 milestone Feb 2, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Feb 2, 2017

There now is a new release, could you please test it and report if it works for you?

@dtougas

This comment has been minimized.

dtougas commented Feb 2, 2017

The new release appears to have fixed the problem. I can now properly save colours on MacOS X. Thank you!

@pbek

This comment has been minimized.

Owner

pbek commented Feb 2, 2017

Great, thank you for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment