New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insertion of link #646

Closed
bepolymathe opened this Issue Jul 27, 2017 · 16 comments

Comments

Projects
None yet
2 participants
@bepolymathe

bepolymathe commented Jul 27, 2017

Hello,

A quick message for a suggestion. When you insert a link with Ctrl + L (or by the menu), you get <link> or [] (link) depending on the url ...

I explain myself in image ...

link1

link2

link 3

link 4

Do you think it will be possible that Qownnotes recognizes "www.link.com" and "link.com" as full url?

@pbek pbek added the enhancement label Jul 27, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Jul 27, 2017

Thank you for your suggestion.

@bepolymathe

This comment has been minimized.

bepolymathe commented Jul 28, 2017

Moreover, I also notice as a consequence that the preview of the <www.google.com> link does not work (in preview panel). Users, you have to add https:// at the beginning of link for see it.

@pbek

This comment has been minimized.

Owner

pbek commented Jul 28, 2017

Yes, they have. <www.google.com> is no URL, it could be all kind of stuff, like a file. ;)

@pbek

This comment has been minimized.

Owner

pbek commented Jul 29, 2017

17.07.9

  • when entering an url in the link-dialog with Ctrl + L that is
    missing a:// then http:// will automatically added in front of the url

@pbek pbek added this to the 17.07.9 milestone Jul 29, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Jul 29, 2017

There now is a new release, could you please test it and report if it works for you?

@bepolymathe

This comment has been minimized.

bepolymathe commented Jul 29, 2017

Woawww 👏... @pbek Do you take breaks from time to time? 😏
Ok, no problem, i test it when new release arrive in fedora depo...

@pbek

This comment has been minimized.

Owner

pbek commented Jul 29, 2017

I take brakes every day! :)

@bepolymathe

This comment has been minimized.

bepolymathe commented Jul 30, 2017

Hi @pbek, it's strange i can't upgrade qownnotes from the fedora repo.
dnf info qownnotes reply that there are 2 versions in the repo 17.07.7 and 17.07.9
Could you check this ?
Thank in advance

@bepolymathe

This comment has been minimized.

bepolymathe commented Jul 30, 2017

No, that's fine. I found the solution.
And it works for ilnk insertion ;)

@pbek

This comment has been minimized.

Owner

pbek commented Jul 30, 2017

Ah, great. Thank you for testing.
The Fedora packaging is done by OBS: https://build.opensuse.org/package/binaries/home:pbek:QOwnNotes/desktop?repository=Fedora_26

@pbek pbek closed this Jul 30, 2017

@bepolymathe

This comment has been minimized.

bepolymathe commented Jul 31, 2017

Hi @pbek
I just spotted a problem I had not seen the first time.
The insertion of external link (to Internet) works very well but it has destabilized the functioning of the internal links (towards another note).
If I try to create a link to another note, I simply get <http: //> that is the part of code added ...
There must be a problem somewhere. Could you check on your side?
Have a good day.

@pbek

This comment has been minimized.

Owner

pbek commented Jul 31, 2017

Oh, it really is broken now. Thank you for finding out!

@bepolymathe

This comment has been minimized.

bepolymathe commented Jul 31, 2017

Damned. Good luck for the repair.

@pbek

This comment has been minimized.

Owner

pbek commented Aug 1, 2017

17.08.1

  • fixed linking of notes in the link dialog
@bepolymathe

This comment has been minimized.

bepolymathe commented Aug 1, 2017

That's great !

@pbek

This comment has been minimized.

Owner

pbek commented Aug 1, 2017

There now is a new release, could you please test it and report if it works for you?

@pbek pbek modified the milestones: 17.07.9, 17.08.1 Aug 1, 2017

@bepolymathe bepolymathe referenced this issue Aug 18, 2017

Closed

Merge notes #676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment