New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text in Note Edit pane is pushed below bottom of the scroll bar by ---------- seperator #667

Closed
clintonthegeek opened this Issue Aug 12, 2017 · 19 comments

Comments

Projects
None yet
2 participants
@clintonthegeek

clintonthegeek commented Aug 12, 2017

Expected behaviour

When I insert seperators into my text using multiple dashes


the size of the scroll area should increase to reflect the new line added.

Actual behaviour

When adding seperators, the text near the end of the file is pushed down below the scrollable area. The end of the file is hidden, appending new text to the end of the file end up inserting it into the middle, for instance.

Steps to reproduce

Create at text file and insert paragraphs interspersed with --------- elements. Eventually the bug should be reproduced.

@pbek

This comment has been minimized.

Owner

pbek commented Aug 12, 2017

I'm sorry, I couldn't reproduce that. Could you please post a video of the process?

@clintonthegeek

This comment has been minimized.

clintonthegeek commented Aug 12, 2017

I think that the ---------- has something to do with it, but am not sure precisely. I've had the problem several times in the past month, including today. The next time it happens I'll record a screengrab and demonstrate what's up.

@pbek

This comment has been minimized.

Owner

pbek commented Aug 13, 2017

Ok. :)

I will close this issue until there is more information.

@pbek pbek closed this Aug 13, 2017

@clintonthegeek

This comment has been minimized.

clintonthegeek commented Aug 13, 2017

https://youtu.be/RM5Wtdi6Hqo

Okay here is the bug in action. I was mistaken about the -------- element causing the issue since I didn't use it in this note.

Notice how I can pull text up from the cut-off area beneath the scrollbar using the DEL key to erase carriage returns. The text is there but unaccessible. My present workaround is to modify the text file in a 3rd party editor, save it, and reload it in QOwnNotes.

@pbek

This comment has been minimized.

Owner

pbek commented Aug 13, 2017

I only saw the video once and I saw what happened on your screen but not exactly what you were doing... Currently I get the message This video is unavailable. when I open the link. :(

@clintonthegeek

This comment has been minimized.

clintonthegeek commented Aug 13, 2017

Oops! Okay I've made it available again.

@clintonthegeek

This comment has been minimized.

clintonthegeek commented Aug 14, 2017

All the video does is demonstrate that I'm having the issue. The scroll-area is definitely to short for the entirety of the document sometimes. If you've any advice on how I can help you determine the cause, let me know. I don't know why I'd be the only user encountering this problem.

@pbek

This comment has been minimized.

Owner

pbek commented Aug 14, 2017

I don't know if you are scrolling or what you are doing in the video (typing, moving cursor, pasting, scrolling, ...), so I can't really say what is going on...

What happens if you turn on the preview panel?

@clintonthegeek

This comment has been minimized.

clintonthegeek commented Aug 21, 2017

Okay the bug just reoccured for me in order to check. The preview panel shows the document all the way to it's end. Only in the edit panel does is the bottom cut off.

@pbek

This comment has been minimized.

Owner

pbek commented Aug 21, 2017

It's hard to to something about it if I can't reproduce it. :)

@clintonthegeek

This comment has been minimized.

clintonthegeek commented Aug 21, 2017

Maybe it's a Qt bug or something? I'm running Qt 5.9.1 on KDE Neon User edition.

I'll just deal with it, and if I eventually determine precisely how to reliably trigger the bug into action, I'll let you know.

@pbek

This comment has been minimized.

Owner

pbek commented Aug 21, 2017

I also run it on machines with KDE Neon User edition...

I'll just deal with it, and if I eventually determine precisely how to reliably trigger the bug into action, I'll let you know.

ok, keep me posted.

@clintonthegeek

This comment has been minimized.

clintonthegeek commented Aug 28, 2017

Okay, well I can't give you steps, but I have better-documented the bugs behavior now.

The problem only affects some notes, and then sticks to them.

An affected note has been built up non-linearly. I usually make an outline of headings or single-sentences in sequence and then i go up and down the document fleshing out and elaborations each part. I'm constantly changing the document different parts as I grow kernels into paragraphs into sections reorganizing sections up and down. often i reorganize parts using the of X11 select/middle mouse-click clipboard functionality.

After a while of doing this, I'll eventually notice I can't scroll down all the way to the bottom. I'm suddenly missing the last few paragraphs of my note, and what I've thought I've been sticking at the very bottom has actually been inserted near the bottom, but above the missing text.

I can "fix" it by resizing the Note edit panel. I'll resize the window or drag the handle between the Note edit panel and another panel like the note-list. When the affected note is redrawn with new text-wrapping the scrollbar snaps to its proper position, letting me scroll down to the document's actual bottom. Before I figured that quick fix out, I was constantly using the delete-key to pull text upward from the unscrollable area into the visible bottom.

This resize-fix is temporary. It is undone by changing to another note. Going back to the affected note brings the bug back every time, needing another resize-fix to bring back the bottom. Affect is persistent across closing and opening the program. Although, after dealing with it and continuing work, sometimes a note can just stop being affected.

@pbek

This comment has been minimized.

Owner

pbek commented Aug 28, 2017

A rather strange behaviour...

@clintonthegeek

This comment has been minimized.

clintonthegeek commented Aug 28, 2017

Yes! It's only a minor inconvienence now but not annoying to work around any longer. Here is a short video of the "fix". Notice the scrollbar on the note pane.

https://youtu.be/VZhXp4dDP14

@pbek

This comment has been minimized.

Owner

pbek commented Sep 1, 2017

I finally found the culprit!

17.09.0

  • margins for headlines in the note editor are now disabled, because Qt bugs
    are causing multiple problems with them
    • they prevent "undo" in headlines
      (for Issue #520)
    • they generate invisible lines at the end of a note
      (for Issue #667)
    • the cause a crash when reaching the invisible lines when highlighting of
      the current line is turned on (for Issue #701)
@clintonthegeek

This comment has been minimized.

clintonthegeek commented Sep 1, 2017

Great! Thanks for your time and the great software. :)

@pbek

This comment has been minimized.

Owner

pbek commented Sep 1, 2017

I only found out because I had a crash in a single note with the new current line highlighting-feature. :)

@pbek

This comment has been minimized.

Owner

pbek commented Sep 1, 2017

There now is a new release, could you please test it and report if it works for you?

@pbek pbek added this to the 17.09.0 milestone Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment