New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not being able to edit notes with a " in the title #683

Closed
florianklumb opened this Issue Aug 18, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@florianklumb

florianklumb commented Aug 18, 2017

Actual behaviour

If you put a " into a note title, editing stops to work.

See also #682

@pbek

This comment has been minimized.

Owner

pbek commented Aug 18, 2017

I can't reproduce that "issue" on Linux.
Maybe your file system doesn't support that character. That filename would then certainly makes troubles... But on the other hand the " gets removed from the filename...

Can you please explain in more detail and step by step what you did, what happened and what you expected.

@pbek

This comment has been minimized.

Owner

pbek commented Aug 18, 2017

Can you please post the output from the debug settings.
And is there any useful log output if you enable the log widget?

@florianklumb

This comment has been minimized.

florianklumb commented Aug 18, 2017

[Aug 18 15:10:01] [critical]: "Could not store note file: .../Notes/newnote with question mark?.md - Error message: Die Syntax für den Dateinamen, Verzeichnisnamen oder die Datenträgerbezeichnung ist falsch."
[Aug 18 15:10:01] [critical]: "Could not store note file: .../Notes/new note with quotation mark \".md - Error message: Die Syntax für den Dateinamen, Verzeichnisnamen oder die Datenträgerbezeichnung ist falsch."

@florianklumb

This comment has been minimized.

florianklumb commented Aug 18, 2017

So actually this is another case of #682

@pbek

This comment has been minimized.

Owner

pbek commented Aug 21, 2017

17.08.7

  • old notes that were automatically renamed will now only be removed if the new
    note was stored successfully
  • if a note gets renamed automatically because the note title changed it will
    now be checked if the note can actually be stored to the note folder before
    really storing it to be able to attempt to replace additional characters in
    the filename before storing it again in case the note is stored on a
    filesystem with harsher filename restrictions
    • if the note still cannot be stored to disk the 2nd time the error will be
      logged to the log panel like it already was before

@pbek pbek added this to the 17.08.7 milestone Aug 21, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Aug 21, 2017

There now is a new release, could you please test it and report if it works for you?

@pbek pbek closed this Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment