New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in theme editor #690

Closed
bepolymathe opened this Issue Aug 22, 2017 · 15 comments

Comments

Projects
None yet
4 participants
@bepolymathe

bepolymathe commented Aug 22, 2017

Hi @pbek

Expected behaviour

We have a great script that allows you to insert [Comment]: # ()
It would be great if we can attribute a color to this text.

Actual behaviour

Only htlm (comment) can be highlight.

@pbek pbek added the enhancement label Aug 22, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Aug 22, 2017

Which markdown "standard" should that represent? Are there examples / references?

@bepolymathe

This comment has been minimized.

bepolymathe commented Aug 22, 2017

It's for example a lot of people use it with Rmarkdown for academic papers. It's well recognize par QON preview... contrary to format <!--- comment-->

Editor panel

capture du 2017-08-22 10-05-42

Preview panel

capture du 2017-08-22 10-06-02

See discussion here

@pbek

This comment has been minimized.

Owner

pbek commented Aug 22, 2017

Well enough, then I will attempt to add that.

@Maboroshy

This comment has been minimized.

Contributor

Maboroshy commented Aug 22, 2017

This syntax for comments is a reference-style link label. That's why markdown parsers don't render it.

@bepolymathe

This comment has been minimized.

bepolymathe commented Aug 22, 2017

Nice @pbek and thank you for precisions @Maboroshy

@pbek

This comment has been minimized.

Owner

pbek commented Aug 22, 2017

17.08.8

  • fixed some highlighting-issues with <!-- --> comments
  • added highlighting for Rmarkdown comments like [Comment]: # (text)

@pbek pbek added this to the 17.08.8 milestone Aug 22, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Aug 22, 2017

There now is a new release, could you please test it and report if it works for you?

@bepolymathe

This comment has been minimized.

bepolymathe commented Aug 22, 2017

Hi,

It seems to work but only with the strict formulation [Comment] : # (text) but the @Maboroshy 's script allows to change, in your language for example. For me, in French, it's [Commentaire] : # (texte). Change the word between [] works fine for exportation in Rstudio (for example). Maybe it's possible to allow emphasis on general formulation [] : # ()
It's just to keep open the potentiality of the script. But it's not a big problem, i can change all my [Commentaire] for [Comment]...

@pbek

This comment has been minimized.

Owner

pbek commented Aug 22, 2017

@bepolymathe

This comment has been minimized.

bepolymathe commented Aug 22, 2017

Yes excuse for not clear informations (-;

@pbek

This comment has been minimized.

Owner

pbek commented Aug 23, 2017

17.08.9

  • improved highlighting for Rmarkdown comments like [Comment]: # (text)
@bepolymathe

This comment has been minimized.

bepolymathe commented Aug 23, 2017

Thanks ;)

@pbek

This comment has been minimized.

Owner

pbek commented Aug 23, 2017

There now is a new release, could you please test it and report if it works for you?

@vve1505

This comment has been minimized.

vve1505 commented Aug 23, 2017

@pbek - just upgraded to 17.08.9 to test the comment feature - works well for me on Ubuntu 17.04.
Great feature!

@pbek

This comment has been minimized.

Owner

pbek commented Aug 23, 2017

Great, thank you for testing! :)

@pbek pbek closed this Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment