New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut to workspace is lost after restart #697

Closed
pklopotowski opened this Issue Aug 26, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@pklopotowski

pklopotowski commented Aug 26, 2017

Expected behaviour

Should properly handle defined shortcut to a particular workspace

Actual behaviour

The shortcut is lost after restart of QOwnNotes.

Steps to reproduce

  • Create a new (or use existing) workspace.
  • Define a shortcut for choosen workspace and save. Shortcut works as expected.
  • Close a QOwnNotes.
  • Check QOwnNotes.conf file. The shortcuts exists in section:
[Shortcuts]
MainWindow-restoreWorkspace1=Alt+Shift+E
  • Run QOwnNotes and check previously defined shortcut -> not works
  • Check the configuration. There is no defined shortcuts.
  • The particular shortcut still exists in the config file

Installation details:
QOwnNotes - version 17.08.10 - AUR - build 372
Built on Aug 25 2017 with Qt 5.9.1.
System: Arch linux
Cinnamon: 3.4.4
kernel: 4.12.8

@pbek

This comment has been minimized.

Owner

pbek commented Aug 27, 2017

Thank you for reporting, that might be a tricky one, since the workspaces are user-generated...

@pklopotowski

This comment has been minimized.

pklopotowski commented Aug 28, 2017

what is also inconvenient that in configuration script (QOwnNotes.conf) in one place a workspace is marked as
[workspace-0367633f-cccd-4b6e-be46-6ec06df66ee9]
but in shortcuts section:

[Shortcuts]
MainWindow-restoreWorkspace1=Alt+Shift+E
@pbek

This comment has been minimized.

Owner

pbek commented Aug 28, 2017

It's a representation of the internal object-name of the menu-items. The shortcut settings dialog fetches its data directly from the user-interface. That's also the reason that not everything might work, because the menu-items might be generated at run-time (like in the case of the workspaces).

It will need some special handling (if possible at all) to make shortcuts work for workspaces like they should.

@pbek

This comment has been minimized.

Owner

pbek commented Aug 30, 2017

17.08.11

  • the shortcuts for restoring workspaces will now be correctly restored after restart

@pbek pbek added this to the 17.08.11 milestone Aug 30, 2017

@pbek

This comment has been minimized.

Owner

pbek commented Aug 30, 2017

There now is a new release, could you please test it and report if it works for you?

@pklopotowski

This comment has been minimized.

pklopotowski commented Aug 30, 2017

works like a charm. great job. thx a lot

@pbek

This comment has been minimized.

Owner

pbek commented Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment