Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight line under edition #701

Closed
ludenticus opened this issue Aug 28, 2017 · 10 comments
Closed

Highlight line under edition #701

ludenticus opened this issue Aug 28, 2017 · 10 comments
Labels
Type: Feature adds functionality
Milestone

Comments

@ludenticus
Copy link
Contributor

As a follow-up of issue 698.

The goal is to find easily what is the line under edition.

Expected behaviour

Highlight the cursor line

Actual behaviour

No highlighting

MockUp

http://doc.qt.io/qt-5/qtwidgets-widgets-codeeditor-example.html

codeeditor-example

@pbek pbek added the Type: Feature adds functionality label Aug 28, 2017
@pbek
Copy link
Owner

pbek commented Aug 28, 2017

I hope the QTextEdit also has those signals...

@pbek
Copy link
Owner

pbek commented Aug 30, 2017

17.08.11

  • the current line will now by default highlighted
    • you can turn that feature off in the Editor settings
    • the background color can be selected as part of the theming in the
      Editor fonts & colors settings
      • a sane default color was chosen for each of the current schemes

@pbek pbek added this to the 17.08.11 milestone Aug 30, 2017
@pbek
Copy link
Owner

pbek commented Aug 30, 2017

There now is a new release, could you please test it and report if it works for you?

@Maboroshy
Copy link
Contributor

Works for me.

@pbek
Copy link
Owner

pbek commented Aug 30, 2017

Great, thank you for testing!

@pbek pbek closed this as completed Aug 30, 2017
@pbek
Copy link
Owner

pbek commented Aug 30, 2017

I'll just adjust the background color for the for the Dark and AnalyticalYellow theme again...

@ludenticus
Copy link
Contributor Author

ludenticus commented Aug 30, 2017

Great!

I use mainly the light theme, and it's perfect. I've tested others, and found that

  • Dark and Analytical Yellow have a minor problem: heading indicators (#) are hard to read

  • Bépolymathe Colorize has a major problem: highlighted line in paragraph text is hard to read

@pbek
Copy link
Owner

pbek commented Aug 31, 2017

Thank you for testing!

@pbek
Copy link
Owner

pbek commented Sep 1, 2017

17.09.0

  • margins for headlines in the note editor are now disabled, because Qt bugs
    are causing multiple problems with them
    • they prevent "undo" in headlines
      (for Issue #520)
    • they generate invisible lines at the end of a note
      (for Issue #667)
    • the cause a crash when reaching the invisible lines when highlighting of
      the current line is turned on (for Issue #701)

@pbek
Copy link
Owner

pbek commented Sep 1, 2017

in addition:

  • improved background color of current line highlighting for the schemas Dark,
    AnalyticalYellow, Bépolymathe Colorize and Mountain

There now is a new release, could you please test it and report if it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature adds functionality
Projects
None yet
Development

No branches or pull requests

3 participants